Detect last readable dialogue line on current title

[arnaucmd]

I would like to implement a simple system that shows some dots "..." when there is more dialogue to come. My issue is I don't know how to detect if this line is the last one in the dialogue. I see there is resource.lines that contains ALL the titles and all the lines, even if they are not readable, like code or similar. Is there a simple way to apprach this that I'm missing? Thanks!

[Fireye04]

So in the balloon the chain of dialogue is exposed similarly to a tree structure (or linked list if it's linear), where each "line" contains a reference for the next. If the next line is empty, and there are no responses, that means the dialogue ends. Docs reference

I gave it a quick test and using the following to debug:

GD.Print(await DialogueManager.GetNextDialogueLine(resource, dialogueLine.NextId, temporaryGameStates));
GD.Print(dialogueLine.Responses);

It looks like the dialogue will end when the first expression is null and the second is an empty array, so I'd suggest implementing an if statement in your bubble that disables a three dots UI element if the above occurs. (this requires a custom bubble, which you can get by cloning the default one under addons/dialogue-manager/example-balloon and pointing to in the GDM project settings)

[arnaucmd]

Hi, thanks a lot for your answer. It works perfectly except when next line is a code line. It seems the first line you provided is not a passive checker and does more stuff, because dialogue closes immediatly in this case. This is my function, I call it at the end of apply_dialogue_line() like this:

chek_and_toggle_dots(dialogue_line.next_id)

The function:

func chek_and_toggle_dots(next_id:String):
	var _is_last_line:bool=false
	var next_line=await DialogueManager.get_next_dialogue_line(resource, dialogue_line.next_id, temporary_game_states)
	var responses=dialogue_line.responses
	if next_line==null and responses.is_empty():
		_is_last_line=true
	if _is_last_line:
		next_line_dots.hide()
	else:
		next_line_dots.show()

This is the dialogue that closes after finishing the first line. I think it's related to the next line being a code only line:

I don't think it's related but I'm on 3.5.0, should I update to 3.7.1? Everything works for me now except this, so I'm kind of afraid to update hehe

[Fireye04]

So oddly the mutation has to be between a dialogue option and a series of responses for this behavior to occur. Mutations themselves work fine. Simplest solution would be to just avoid that pattern in writing dialogue, but that does seem like it should pass through the response list, so I'd say go ahead and open an issue for this bug.

[arnaucmd]

I don't understand the bug exactly though, what should I write? "await DialogueManager.get_next_dialogue_line(resource, dialogue_line.next_id, temporary_game_states) returns null when next dialogue line is a code line."?

[Fireye04]

Wow ok, so that was a journey. Long story short, you can check for null types using the get_line command (not get_next_dialogue_line), as it will only return null if the dialogue is ending, and an empty object otherwise. This is not a bug, it's just how the engine works. get_next_dialogue_line just causes problems. You should be able to call get_line from the same method signature. (If you're in C# I opened a PR adding get_line to C# so you'll have to either patch in the extra code or just wait for it to get merged.)

[arnaucmd]

thank you! works perfect