Fix RAM share creation when a targetted OU contains inactive accounts (#106)

kurtismash · web-flow · commit 99337caf9d54 · 2025-11-12T17:29:27.000Z
diff --git a/modules/service-deployment/regional.tf b/modules/service-deployment/regional.tf
@@ -4,6 +4,11 @@ data "aws_organizations_organizational_unit_descendant_accounts" "target_account
   parent_id = each.key
 }
 
+locals {
+  ram_target_accounts    = try(flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[*].accounts[*]), [])
+  ram_target_account_ids = [for a in local.ram_target_accounts : a.id if a.state == "ACTIVE"]
+}
+
 #
 # Module for deploying AWS Backup resources in a specific region.
 #
@@ -50,7 +55,7 @@ module "region" {
   ram = {
     create_lag_shares  = local.create_lag_shares
     lag_share_name     = local.lag_share_name
-    target_account_ids = try(flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[*].accounts[*].id), [])
+    target_account_ids = local.ram_target_account_ids
   }
   stepfunctions = {
     ingest_state_machine_name          = local.ingest_state_machine_name

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,11 @@ data "aws_organizations_organizational_unit_descendant_accounts" "target_account`
`4`	`4`	`parent_id = each.key`
`5`	`5`	`}`
`6`	`6`
	`7`	`+locals {`
	`8`	`+ ram_target_accounts = try(flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[].accounts[]), [])`
	`9`	`+ ram_target_account_ids = [for a in local.ram_target_accounts : a.id if a.state == "ACTIVE"]`
	`10`	`+}`
	`11`	`+`
`7`	`12`	`#`
`8`	`13`	`# Module for deploying AWS Backup resources in a specific region.`
`9`	`14`	`#`
`@@ -50,7 +55,7 @@ module "region" {`
`50`	`55`	`ram = {`
`51`	`56`	`create_lag_shares = local.create_lag_shares`
`52`	`57`	`lag_share_name = local.lag_share_name`
`53`		`- target_account_ids = try(flatten(values(data.aws_organizations_organizational_unit_descendant_accounts.target_accounts)[].accounts[].id), [])`
	`58`	`+ target_account_ids = local.ram_target_account_ids`
`54`	`59`	`}`
`55`	`60`	`stepfunctions = {`
`56`	`61`	`ingest_state_machine_name = local.ingest_state_machine_name`