Skip to content

Commit 5488853

Browse files
committed
fsx: update FIXME with better understanding
This comment was missing the mention of 'dotnet tool install'.
1 parent 304fc20 commit 5488853

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

fsx/Program.fs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,11 @@ let finalLaunch =
160160
}
161161

162162
let finalProc = Process.Execute(finalLaunch, Echo.OutputOnly)
163-
// FIXME: maybe using a .fsx file as a launcher in Windows wasn't the best idea after all, because it means
164-
// that, on Windows, fsx will run fsharpi while the compiled user script is running, which means that the
165-
// memory gains of using fsx instead of fsharpi (as explained in the ReadMe.md file) don't exist for this OS
166-
// (while in Unix, i.e. Linux and macOS, they exist because we use a bash script which uses 'exec')
163+
// FIXME: maybe using an F# file as a launcher wasn't the best idea after all, because it means that, on
164+
// Windows (and in Unix when installed via 'dotnet tool install fsx'), fsx will be running 'dotnet fsi' (or 'fsharpi')
165+
// while the compiled user script is running, which means that the memory gains of using fsx instead of fsharpi
166+
// (as explained in the ReadMe.md file) don't exist for this OS (while in Unix, i.e. Linux and macOS, when the
167+
// tool is not installed via `dotnet tool install fsx`, they exist because we use a bash script which uses 'exec')
167168
match finalProc.Result with
168169
| Error(exitCode, _errOutput) -> Environment.Exit exitCode
169170
| _ -> Environment.Exit 0

0 commit comments

Comments
 (0)