Skip to content

Commit b1cb8ba

Browse files
authored
Add aria-label to select elements (#346)
1 parent a5b4b37 commit b1cb8ba

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/partials/nav-cheat-sheet.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{{#if (eq page.attributes.theme 'cheat-sheet') }}
22
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="products">
33
<div class="dropdown">
4-
<select id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
4+
<select aria-label="Product" id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
55
{{!-- <option value="all" data-label="all" data-class="all" data-label-type="products">All</option> --}}
66
{{#each page.attributes.cheatsheet-products}}
77
{{#if this.default}}
@@ -23,7 +23,7 @@
2323
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="categories">
2424
{{!-- categories - eg read, write, structure, general --}}
2525
<div class="dropdown">
26-
<select id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
26+
<select aria-label="Cypher category" id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
2727
<option value="all" data-label="all" data-class="all" data-label-type="categories">All</option>
2828
{{#each page.attributes.cheatsheet-categories}}
2929
{{#if this.default}}

src/partials/nav-explore.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="dropdown">
55
<span class="dropdown-label">Neo4j Version</span>
66

7-
<select data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
7+
<select aria-label="Version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
88
{{#each page.versions}}
99
{{#unless (or this.prerelease (and (eq this.version @root.page.version) (eq @root.page.attributes.theme 'cheat-sheet') ))}}
1010
<option

src/partials/nav-selectors.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div class="dropdown">
1616
<span class="dropdown-label">{{#with (or page.attributes.cheatsheet-product 'Product')}}{{this}}{{/with}} Version</span>
1717

18-
<select id="selector-version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
18+
<select aria-label="Version" id="selector-version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
1919
{{#each page.versions}}
2020
{{#unless (and this.prerelease @root.page.attributes.nav-selectors-hide-prerelease)}}
2121
<option
@@ -41,7 +41,7 @@
4141
<div class="selectors">
4242
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="products">
4343
<div class="dropdown">
44-
<select id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
44+
<select aria-label="Product" id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
4545
{{!-- <option value="all" data-label="all" data-class="all" data-label-type="products">All</option> --}}
4646
{{#each page.attributes.cheatsheet-products}}
4747
{{#if this.default}}
@@ -63,7 +63,7 @@
6363
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="categories">
6464
{{!-- categories - eg read, write, structure, general --}}
6565
<div class="dropdown">
66-
<select id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
66+
<select aria-label="Cypher category" id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
6767
<option value="all" data-label="all" data-class="all" data-label-type="categories">All</option>
6868
{{#each page.attributes.cheatsheet-categories}}
6969
{{#if this.default}}

0 commit comments

Comments
 (0)