Outdated for s390x

[juru1234]

Hi,

thank you for providing this snap. Is there any reason it is outdated (v0.7.0 on snapcraft.io) for s390x architecture?
It would be nice if you could update it and even better if you could ship it with luajit support.
Because this doesn't get merged a solution could
be to replace the luajit dependency in neovim/cmake.deps/deps.txt with luajit2.

I did a quick test on s390x Ubuntu and the snap was built successfully for neovim 0.10.4 (without luajit support).

[justinmk]

PR welcome. Look at https://github.com/neovim/neovim-snap/blob/master/snap/snapcraft.yaml and find out what changes are needed.

[juru1234]

I tried the existing yaml and it successfully built neovim 0.10.4 on s390x. So why is the snapcraft.io-version then 0.7?

For the luajit-Support we can do a PR :)

[justinmk]

No idea.

The cron jobs are here:
https://github.com/neovim/neovim-snap/actions

but those probably don't help, since the builds are done on snapcraft's environment.

I don't see a way to inspect the snapcraft builds:
https://snapcraft.io/nvim

[hurricanehrndz]

I will have a look today, I think the architecture had been disabled. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Justin M. Keyes ***@***.***> Sent: Thursday, February 13, 2025 6:46:31 AM To: neovim/neovim-snap ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [neovim/neovim-snap] Outdated for s390x (Issue #43) No idea. The cron jobs are here: https://github.com/neovim/neovim-snap/actions but those probably don't help, since the builds are done on snapcraft's environment. I don't see a way to inspect the snapcraft builds: https://snapcraft.io/nvim — Reply to this email directly, view it on GitHub<#43 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMJBTICXHZ7WC25XPDCXVT2PSO3PAVCNFSM6AAAAABXBX5RKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJWGY2DQOJTGU>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[hurricanehrndz]

S390x was disabled, @justinmk I am sure we disabled this because we found build bugs. I have re-enabled them as is, if you all want to try and move to a new luajit, please have it. Build logs are on launchpad
https://launchpad.net/~neovim-snap/neovim-ppa/+snap/nvim-stable
It is the same creds as the snap store

[hurricanehrndz]

@justinmk and @juru1234 s390x was successfully built as is

If you want to build it with luajit2, I leave that conversation up to the two of you

[juru1234]

@hurricanehrndz Thank you very much!

[justinmk]

luajit isn't a priority. Something that works is better than nothing for now.

[juru1234]

@hurricanehrndz I think the nightly build does still not run for s390x. For the luajit-support I made a PR #44

[hurricanehrndz]

K, I will turn that on soon