From 7839049bd5c1e19a464a474f7f63c06067a847e7 Mon Sep 17 00:00:00 2001 From: Callista Hoxie Date: Mon, 23 Sep 2024 10:02:40 -0500 Subject: [PATCH] feat(ansible_check_mode): try add support for ansible check mode --- roles/netbootxyz/tasks/generate_checksums.yml | 4 ++++ roles/netbootxyz/tasks/generate_disks_arm.yml | 1 + roles/netbootxyz/tasks/generate_disks_base.yml | 2 ++ roles/netbootxyz/tasks/generate_disks_efi.yml | 1 + roles/netbootxyz/tasks/generate_disks_legacy.yml | 3 +++ roles/netbootxyz/tasks/generate_disks_linux.yml | 1 + roles/netbootxyz/tasks/generate_disks_rpi.yml | 4 ++++ roles/netbootxyz/tasks/generate_menus_custom.yml | 1 + roles/netbootxyz/tasks/generate_signatures.yml | 2 ++ 9 files changed, 19 insertions(+) diff --git a/roles/netbootxyz/tasks/generate_checksums.yml b/roles/netbootxyz/tasks/generate_checksums.yml index 2ad99c8c9b..d16fe7e92d 100644 --- a/roles/netbootxyz/tasks/generate_checksums.yml +++ b/roles/netbootxyz/tasks/generate_checksums.yml @@ -2,10 +2,12 @@ - name: Register a listing of all created iPXE bootloaders ansible.builtin.command: ls -I {{ checksums_filename }} {{ netbootxyz_root }}/ipxe/ register: netboot_disks + check_mode: False - name: Generate date ansible.builtin.command: date register: current_date + check_mode: False - name: Gather stat listing of directory ansible.builtin.command: sha256sum -b {{ item }} @@ -14,6 +16,7 @@ args: chdir: "{{ netbootxyz_root }}/ipxe/" register: netboot_disks_stat + check_mode: False - name: Generate ipxe disk checksums ansible.builtin.template: @@ -24,6 +27,7 @@ ansible.builtin.shell: toilet -f standard {{ site_name }} --html | grep span register: index_title when: ansible_os_family == "Debian" + check_mode: False - name: Reset bootloader filename to first in list ansible.builtin.set_fact: diff --git a/roles/netbootxyz/tasks/generate_disks_arm.yml b/roles/netbootxyz/tasks/generate_disks_arm.yml index 43f84416f3..a5a6eecccb 100644 --- a/roles/netbootxyz/tasks/generate_disks_arm.yml +++ b/roles/netbootxyz/tasks/generate_disks_arm.yml @@ -66,6 +66,7 @@ src: "{{ ipxe_source_dir }}/src/{{ item.src }}" dest: "{{ netbootxyz_root }}/ipxe/{{ item.dest }}" remote_src: true + ignore_errors: "{{ ansible_check_mode }}" with_items: - {src: "bin-arm64-efi/ipxe.efi", dest: "{{ bootloader_filename }}-arm64.efi"} - {src: "bin-arm64-efi/snp.efi", dest: "{{ bootloader_filename }}-arm64-snp.efi"} diff --git a/roles/netbootxyz/tasks/generate_disks_base.yml b/roles/netbootxyz/tasks/generate_disks_base.yml index 946b45e5d5..3f56c91788 100644 --- a/roles/netbootxyz/tasks/generate_disks_base.yml +++ b/roles/netbootxyz/tasks/generate_disks_base.yml @@ -61,11 +61,13 @@ ansible.builtin.template: src: "disks/{{ bootloader_filename }}.j2" dest: "{{ ipxe_source_dir }}/src/{{ bootloader_filename }}" + ignore_errors: "{{ ansible_check_mode }}" - name: Touch iPXE config local files ansible.builtin.file: path: "{{ ipxe_source_dir }}/{{ item }}" state: touch + ignore_errors: "{{ ansible_check_mode }}" with_items: - src/config/local/umalloc.h - src/config/local/nap.h diff --git a/roles/netbootxyz/tasks/generate_disks_efi.yml b/roles/netbootxyz/tasks/generate_disks_efi.yml index dec250b30d..d167684390 100644 --- a/roles/netbootxyz/tasks/generate_disks_efi.yml +++ b/roles/netbootxyz/tasks/generate_disks_efi.yml @@ -56,6 +56,7 @@ src: "{{ ipxe_source_dir }}/src/{{ item.src }}" dest: "{{ netbootxyz_root }}/ipxe/{{ item.dest }}" remote_src: true + ignore_errors: "{{ ansible_check_mode }}" with_items: - {src: "bin-x86_64-efi/ipxe.efi", dest: "{{ bootloader_filename }}.efi"} - {src: "bin-x86_64-efi/snp.efi", dest: "{{ bootloader_filename }}-snp.efi"} diff --git a/roles/netbootxyz/tasks/generate_disks_legacy.yml b/roles/netbootxyz/tasks/generate_disks_legacy.yml index 2900b60168..05be98b1b6 100644 --- a/roles/netbootxyz/tasks/generate_disks_legacy.yml +++ b/roles/netbootxyz/tasks/generate_disks_legacy.yml @@ -56,6 +56,7 @@ src: "{{ ipxe_source_dir }}/src/bin/ipxe{{ item }}" dest: "{{ netbootxyz_root }}/ipxe/{{ bootloader_filename }}{{ item }}" remote_src: true + ignore_errors: "{{ ansible_check_mode }}" with_items: - ".pdsk" - ".dsk" @@ -68,6 +69,7 @@ src: "{{ ipxe_source_dir }}/src/bin/ipxe{{ item }}" dest: "{{ netbootxyz_root }}/ipxe/{{ bootloader_filename }}{{ item }}" remote_src: true + ignore_errors: "{{ ansible_check_mode }}" with_items: - ".kpxe" when: bootloader_filename == "netboot.xyz-metal" @@ -77,4 +79,5 @@ src: "{{ ipxe_source_dir }}/src/bin/undionly.kpxe" dest: "{{ netbootxyz_root }}/ipxe/{{ bootloader_filename }}-undionly.kpxe" remote_src: true + ignore_errors: "{{ ansible_check_mode }}" when: bootloader_filename != "netboot.xyz-metal" diff --git a/roles/netbootxyz/tasks/generate_disks_linux.yml b/roles/netbootxyz/tasks/generate_disks_linux.yml index a82d32b5f1..dde53d335e 100644 --- a/roles/netbootxyz/tasks/generate_disks_linux.yml +++ b/roles/netbootxyz/tasks/generate_disks_linux.yml @@ -52,4 +52,5 @@ src: "{{ ipxe_source_dir }}/src/bin-x86_64-linux/slirp.linux" dest: "{{ netbootxyz_root }}/ipxe/{{ bootloader_filename }}-linux.bin" remote_src: true + ignore_errors: "{{ ansible_check_mode }}" when: bootloader_filename != "netboot.xyz-metal" diff --git a/roles/netbootxyz/tasks/generate_disks_rpi.yml b/roles/netbootxyz/tasks/generate_disks_rpi.yml index 14b665750d..34a1401cc8 100644 --- a/roles/netbootxyz/tasks/generate_disks_rpi.yml +++ b/roles/netbootxyz/tasks/generate_disks_rpi.yml @@ -18,11 +18,13 @@ ansible.builtin.template: src: "disks/{{ bootloader_filename }}.j2" dest: "{{ pipxe_source_dir }}/ipxe/src/{{ bootloader_filename }}" + ignore_errors: "{{ ansible_check_mode }}" - name: Copy netboot.xyz local EFI iPXE configs ansible.builtin.copy: src: "ipxe/local/{{ item }}" dest: "{{ pipxe_source_dir }}/ipxe/src/config/local/{{ item }}" + ignore_errors: "{{ ansible_check_mode }}" with_items: - colour.h - console.h @@ -32,6 +34,7 @@ ansible.builtin.copy: src: "ipxe/local/general.h.efi" dest: "{{ pipxe_source_dir }}/ipxe/src/config/local/general.h" + ignore_errors: "{{ ansible_check_mode }}" - name: Set trust file to ipxe ca ansible.builtin.set_fact: @@ -59,6 +62,7 @@ src: "{{ pipxe_source_dir }}/{{ item.src }}" dest: "{{ netbootxyz_root }}/ipxe/{{ item.dest }}" remote_src: true + ignore_errors: "{{ ansible_check_mode }}" with_items: - {src: "sdcard.img", dest: "{{ bootloader_filename }}-rpi4-sdcard.img"} - {src: "ipxe/src/bin-arm64-efi/snp.efi", dest: "{{ bootloader_filename }}-rpi4-snp.efi"} diff --git a/roles/netbootxyz/tasks/generate_menus_custom.yml b/roles/netbootxyz/tasks/generate_menus_custom.yml index cf15752314..951cc438f5 100644 --- a/roles/netbootxyz/tasks/generate_menus_custom.yml +++ b/roles/netbootxyz/tasks/generate_menus_custom.yml @@ -14,3 +14,4 @@ dest: "{{ netbootxyz_root }}/custom/{{ item.path | regex_replace('.j2', '') }}" with_community.general.filetree: "{{ custom_templates_dir }}" when: item.state == "file" + ignore_errors: "{{ ansible_check_mode }}" diff --git a/roles/netbootxyz/tasks/generate_signatures.yml b/roles/netbootxyz/tasks/generate_signatures.yml index d05b5eca8b..eddddb35e8 100644 --- a/roles/netbootxyz/tasks/generate_signatures.yml +++ b/roles/netbootxyz/tasks/generate_signatures.yml @@ -2,6 +2,7 @@ - name: Gather list of source files ansible.builtin.command: ls {{ netbootxyz_root }} register: source_files + check_mode: False - name: Create directories for signatures ansible.builtin.file: @@ -19,3 +20,4 @@ chdir: "{{ cert_dir }}" with_items: - "{{ source_files.stdout_lines }}" + ignore_errors: "{{ ansible_check_mode }}"