Skip to content

Commit 3140060

Browse files
authored
Merge pull request #20951 from netbox-community/20925-comments-oranizationalmodel
Add comments to OrganizationalModel
2 parents 8719fd4 + 607a385 commit 3140060

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+283
-82
lines changed

netbox/circuits/api/serializers_/circuits.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class CircuitTypeSerializer(OrganizationalModelSerializer):
3838
class Meta:
3939
model = CircuitType
4040
fields = [
41-
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'tags',
41+
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'comments', 'tags',
4242
'custom_fields', 'created', 'last_updated', 'circuit_count',
4343
]
4444
brief_fields = ('id', 'url', 'display', 'name', 'slug', 'description', 'circuit_count')
@@ -71,7 +71,7 @@ class CircuitGroupSerializer(OrganizationalModelSerializer):
7171
class Meta:
7272
model = CircuitGroup
7373
fields = [
74-
'id', 'url', 'display_url', 'display', 'name', 'slug', 'description', 'tenant', 'owner', 'tags',
74+
'id', 'url', 'display_url', 'display', 'name', 'slug', 'description', 'tenant', 'owner', 'comments', 'tags',
7575
'custom_fields', 'created', 'last_updated', 'circuit_count'
7676
]
7777
brief_fields = ('id', 'url', 'display', 'name')
@@ -161,7 +161,7 @@ class VirtualCircuitTypeSerializer(OrganizationalModelSerializer):
161161
class Meta:
162162
model = VirtualCircuitType
163163
fields = [
164-
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'tags',
164+
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'comments', 'tags',
165165
'custom_fields', 'created', 'last_updated', 'virtual_circuit_count',
166166
]
167167
brief_fields = ('id', 'url', 'display', 'name', 'slug', 'description', 'virtual_circuit_count')

netbox/circuits/forms/bulk_edit.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ class CircuitTypeBulkEditForm(OrganizationalModelBulkEditForm):
9999
fieldsets = (
100100
FieldSet('color', 'description'),
101101
)
102-
nullable_fields = ('color', 'description')
102+
nullable_fields = ('color', 'description', 'comments')
103103

104104

105105
class CircuitBulkEditForm(PrimaryModelBulkEditForm):
@@ -241,7 +241,7 @@ class CircuitGroupBulkEditForm(OrganizationalModelBulkEditForm):
241241

242242
model = CircuitGroup
243243
nullable_fields = (
244-
'description', 'tenant',
244+
'description', 'tenant', 'comments',
245245
)
246246

247247

@@ -274,7 +274,7 @@ class VirtualCircuitTypeBulkEditForm(OrganizationalModelBulkEditForm):
274274
fieldsets = (
275275
FieldSet('color', 'description'),
276276
)
277-
nullable_fields = ('color', 'description')
277+
nullable_fields = ('color', 'description', 'comments')
278278

279279

280280
class VirtualCircuitBulkEditForm(PrimaryModelBulkEditForm):

netbox/circuits/forms/bulk_import.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class CircuitTypeImportForm(OrganizationalModelImportForm):
7373

7474
class Meta:
7575
model = CircuitType
76-
fields = ('name', 'slug', 'color', 'description', 'owner', 'tags')
76+
fields = ('name', 'slug', 'color', 'description', 'owner', 'comments', 'tags')
7777

7878

7979
class CircuitImportForm(PrimaryModelImportForm):
@@ -176,7 +176,7 @@ class CircuitGroupImportForm(OrganizationalModelImportForm):
176176

177177
class Meta:
178178
model = CircuitGroup
179-
fields = ('name', 'slug', 'description', 'tenant', 'owner', 'tags')
179+
fields = ('name', 'slug', 'description', 'tenant', 'owner', 'comments', 'tags')
180180

181181

182182
class CircuitGroupAssignmentImportForm(NetBoxModelImportForm):
@@ -199,7 +199,7 @@ class VirtualCircuitTypeImportForm(OrganizationalModelImportForm):
199199

200200
class Meta:
201201
model = VirtualCircuitType
202-
fields = ('name', 'slug', 'color', 'description', 'owner', 'tags')
202+
fields = ('name', 'slug', 'color', 'description', 'owner', 'comments', 'tags')
203203

204204

205205
class VirtualCircuitImportForm(PrimaryModelImportForm):

netbox/circuits/forms/model_forms.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class CircuitTypeForm(OrganizationalModelForm):
9797
class Meta:
9898
model = CircuitType
9999
fields = [
100-
'name', 'slug', 'color', 'description', 'tags',
100+
'name', 'slug', 'color', 'description', 'comments', 'tags',
101101
]
102102

103103

@@ -236,7 +236,7 @@ class CircuitGroupForm(TenancyForm, OrganizationalModelForm):
236236
class Meta:
237237
model = CircuitGroup
238238
fields = [
239-
'name', 'slug', 'description', 'tenant_group', 'tenant', 'owner', 'tags',
239+
'name', 'slug', 'description', 'tenant_group', 'tenant', 'owner', 'comments', 'tags',
240240
]
241241

242242

@@ -307,7 +307,7 @@ class VirtualCircuitTypeForm(OrganizationalModelForm):
307307
class Meta:
308308
model = VirtualCircuitType
309309
fields = [
310-
'name', 'slug', 'color', 'description', 'owner', 'tags',
310+
'name', 'slug', 'color', 'description', 'owner', 'comments', 'tags',
311311
]
312312

313313

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Generated by Django 5.2.8 on 2025-12-08 17:38
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('circuits', '0054_cable_position'),
10+
]
11+
12+
operations = [
13+
migrations.AddField(
14+
model_name='circuitgroup',
15+
name='comments',
16+
field=models.TextField(blank=True),
17+
),
18+
migrations.AddField(
19+
model_name='circuittype',
20+
name='comments',
21+
field=models.TextField(blank=True),
22+
),
23+
migrations.AddField(
24+
model_name='virtualcircuittype',
25+
name='comments',
26+
field=models.TextField(blank=True),
27+
),
28+
]

netbox/circuits/search.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class CircuitGroupIndex(SearchIndex):
2020
('name', 100),
2121
('slug', 110),
2222
('description', 500),
23+
('comments', 5000),
2324
)
2425
display_attrs = ('description',)
2526

@@ -44,6 +45,7 @@ class CircuitTypeIndex(SearchIndex):
4445
('name', 100),
4546
('slug', 110),
4647
('description', 500),
48+
('comments', 5000),
4749
)
4850
display_attrs = ('description',)
4951

@@ -109,5 +111,6 @@ class VirtualCircuitTypeIndex(SearchIndex):
109111
('name', 100),
110112
('slug', 110),
111113
('description', 500),
114+
('comments', 5000),
112115
)
113116
display_attrs = ('description',)

netbox/circuits/tables/circuits.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ class CircuitTypeTable(OrganizationalModelTable):
4040
class Meta(OrganizationalModelTable.Meta):
4141
model = CircuitType
4242
fields = (
43-
'pk', 'id', 'name', 'circuit_count', 'color', 'description', 'slug', 'tags', 'created', 'last_updated',
44-
'actions',
43+
'pk', 'id', 'name', 'circuit_count', 'color', 'description', 'slug', 'comments', 'tags', 'created',
44+
'last_updated', 'actions',
4545
)
4646
default_columns = ('pk', 'name', 'circuit_count', 'color', 'description')
4747

@@ -175,7 +175,7 @@ class CircuitGroupTable(OrganizationalModelTable):
175175
class Meta(OrganizationalModelTable.Meta):
176176
model = CircuitGroup
177177
fields = (
178-
'pk', 'name', 'description', 'circuit_group_assignment_count', 'tags',
178+
'pk', 'name', 'description', 'circuit_group_assignment_count', 'comments', 'tags',
179179
'created', 'last_updated', 'actions',
180180
)
181181
default_columns = ('pk', 'name', 'description', 'circuit_group_assignment_count')

netbox/dcim/api/serializers_/manufacturers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ class ManufacturerSerializer(OrganizationalModelSerializer):
1818
class Meta:
1919
model = Manufacturer
2020
fields = [
21-
'id', 'url', 'display_url', 'display', 'name', 'slug', 'description', 'owner', 'tags', 'custom_fields',
22-
'created', 'last_updated', 'devicetype_count', 'moduletype_count', 'inventoryitem_count', 'platform_count',
21+
'id', 'url', 'display_url', 'display', 'name', 'slug', 'description', 'owner', 'comments', 'tags',
22+
'custom_fields', 'created', 'last_updated', 'devicetype_count', 'moduletype_count', 'inventoryitem_count',
23+
'platform_count',
2324
]
2425
brief_fields = ('id', 'url', 'display', 'name', 'slug', 'description', 'devicetype_count')

netbox/dcim/api/serializers_/racks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class RackRoleSerializer(OrganizationalModelSerializer):
3030
class Meta:
3131
model = RackRole
3232
fields = [
33-
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'tags',
33+
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'comments', 'tags',
3434
'custom_fields', 'created', 'last_updated', 'rack_count',
3535
]
3636
brief_fields = ('id', 'url', 'display', 'name', 'slug', 'description', 'rack_count')

netbox/dcim/api/serializers_/roles.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class InventoryItemRoleSerializer(OrganizationalModelSerializer):
3838
class Meta:
3939
model = InventoryItemRole
4040
fields = [
41-
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'tags',
41+
'id', 'url', 'display_url', 'display', 'name', 'slug', 'color', 'description', 'owner', 'comments', 'tags',
4242
'custom_fields', 'created', 'last_updated', 'inventoryitem_count',
4343
]
4444
brief_fields = ('id', 'url', 'display', 'name', 'slug', 'description', 'inventoryitem_count')

0 commit comments

Comments
 (0)