fix: skip checking for endpoint existence for hidden redirects (#7067)

Author: VitaliyR

src/utils/proxy.ts

@@ -349,10 +349,14 @@ const serveRedirect = async function ({
   }
 
   const reqUrl = reqToURL(req, req.url)
+  const isHiddenProxy =
+    match.proxyHeaders &&
+    Object.entries(match.proxyHeaders).some(([key, val]) => key.toLowerCase() === 'x-nf-hidden-proxy' && val === 'true')
 
   const staticFile = await getStatic(decodeURIComponent(reqUrl.pathname), options.publicFolder)
   const endpointExists =
     !staticFile &&
+    !isHiddenProxy &&
     process.env.NETLIFY_DEV_SERVER_CHECK_SSG_ENDPOINTS &&
     (await isEndpointExists(decodeURIComponent(reqUrl.pathname), options.target))
   if (staticFile || endpointExists) {
@@ -388,11 +392,6 @@ const serveRedirect = async function ({
         // This is a redirect, so we set the complete external URL as destination
         destURL = `${dest}`
       } else {
-        const isHiddenProxy =
-          match.proxyHeaders &&
-          Object.entries(match.proxyHeaders).some(
-            ([key, val]) => key.toLowerCase() === 'x-nf-hidden-proxy' && val === 'true',
-          )
         if (!isHiddenProxy) {
           console.log(`${NETLIFYDEVLOG} Proxying to ${dest}`)
         }

tests/integration/commands/dev/redirects.test.ts

@@ -1,7 +1,9 @@
+import fetch from 'node-fetch'
 import { describe, expect, test } from 'vitest'
 
+import { withDevServer } from '../../utils/dev-server.js'
 import { FixtureTestContext, setupFixtureTests } from '../../utils/fixture.js'
-import fetch from 'node-fetch'
+import { withSiteBuilder } from '../../utils/site-builder.js'
 
 describe('redirects', () => {
   setupFixtureTests('dev-server-with-functions', { devServer: true }, () => {
@@ -50,4 +52,58 @@ describe('redirects', () => {
       expect(result.toLowerCase()).not.toContain('netlify')
     })
   })
+
+  test('should not check the endpoint existence for hidden proxies', async (t) => {
+    await withSiteBuilder(t, async (builder) => {
+      await builder
+        .withContentFile({
+          path: './index.js',
+          content: `
+          const http = require('http')
+          const server = http.createServer((req, res) => {
+            console.log('Got request main server', req.method, req.url)
+            res.end()
+          })
+          server.listen(6125)
+
+          const proxyServer = http.createServer((req, res) => {
+            console.log('Got request proxy server', req.method, req.url)
+            res.end()
+          })
+          proxyServer.listen(6126)
+          `,
+        })
+        .withNetlifyToml({
+          config: {
+            dev: {
+              targetPort: 6125,
+              command: 'node index.js',
+            },
+            redirects: [
+              {
+                from: '/from-hidden',
+                to: 'http://localhost:6126/to',
+                status: 200,
+                headers: { 'x-nf-hidden-proxy': 'true' },
+              },
+              { from: '/from', to: 'http://localhost:6126/to', status: 200 },
+            ],
+          },
+        })
+        .build()
+
+      await withDevServer(
+        { cwd: builder.directory, env: { NETLIFY_DEV_SERVER_CHECK_SSG_ENDPOINTS: '1' } },
+        async ({ outputBuffer, url }) => {
+          await fetch(new URL('/from-hidden', url))
+          t.expect(String(outputBuffer)).not.toContain('Got request main server')
+          t.expect(String(outputBuffer)).toContain('Got request proxy server GET /to')
+          await fetch(new URL('/from', url))
+          t.expect(String(outputBuffer.join(''))).toContain(
+            'Got request main server HEAD /from\nGot request main server GET /from',
+          )
+        },
+      )
+    })
+  })
 })