PresenterComponentReflection::convertType() objects can be passed only to parameters without array or scalar type (without array / scalar default value) (BC break)

Author: dg

src/Application/UI/PresenterComponentReflection.php

@@ -147,7 +147,7 @@ public static function convertType(& $val, $type)
 			settype($val, $type);
 
 		} elseif (is_object($val)) {
-			// ignore
+			return $type === 'NULL';
 
 		} elseif ($type === 'array') {
 			return is_array($val);

tests/Application/Presenter.link().phpt

@@ -118,7 +118,7 @@ class TestPresenter extends Application\UI\Presenter
 		Assert::same("#error: Invalid value for parameter 'bool' in method TestPresenter::handlebuy(), expected boolean.", $this->link('buy!', 1, 2, 3));
 		Assert::same("#error: Invalid value for parameter 'x' in method TestPresenter::handlebuy(), expected integer.", $this->link('buy!', [[]]));
 		Assert::same('/index.php?action=default&do=buy&presenter=Test', $this->link('buy!'));
-		Assert::same('/index.php?action=default&do=buy&presenter=Test', $this->link('buy!', [new stdClass]));
+		Assert::same("#error: Invalid value for parameter 'x' in method TestPresenter::handlebuy(), expected integer.", $this->link('buy!', [new stdClass]));
 
 		Assert::same('/index.php?a=x&action=default&do=obj&presenter=Test', $this->link('obj!', ['x']));
 		Assert::same('/index.php?action=default&do=obj&presenter=Test', $this->link('obj!', [new stdClass]));

tests/Application/PresenterComponentReflection.convertType.phpt

@@ -16,7 +16,7 @@ require __DIR__ . '/../bootstrap.php';
 //   null (not used)      pass   cast       cast   error      error
 //   scalar               pass   cast/deny  deny   error      error
 //   array                deny   deny       pass   deny       deny
-//   object               pass   pass       error  pass/error pass/error
+//   object               pass   deny       error  pass/error pass/error
 //
 //   error = E_RECOVERABLE_ERROR   * = only as native typehint
 
@@ -36,7 +36,7 @@ $obj = new stdClass;
 
 testIt('string', NULL, '');
 testIt('string', []);
-testIt('string', $obj, $obj);
+testIt('string', $obj);
 testIt('string', '', '');
 testIt('string', 'a', 'a');
 testIt('string', '0', '0');
@@ -53,7 +53,7 @@ testIt('string', 1.2, '1.2');
 
 testIt('int', NULL, 0);
 testIt('int', []);
-testIt('int', $obj, $obj);
+testIt('int', $obj);
 testIt('int', '');
 testIt('int', 'a');
 testIt('int', '0', 0);
@@ -70,7 +70,7 @@ testIt('int', 1.2);
 
 testIt('double', NULL, 0.0);
 testIt('double', []);
-testIt('double', $obj, $obj);
+testIt('double', $obj);
 testIt('double', '');
 testIt('double', 'a');
 testIt('double', '0', 0.0);
@@ -87,7 +87,7 @@ testIt('double', 1.2, 1.2);
 
 testIt('bool', NULL, FALSE);
 testIt('bool', []);
-testIt('bool', $obj, $obj);
+testIt('bool', $obj);
 testIt('bool', '');
 testIt('bool', 'a');
 testIt('bool', '1', TRUE);
@@ -103,7 +103,7 @@ testIt('bool', 1.2);
 
 testIt('array', NULL, []);
 testIt('array', [], []);
-testIt('array', $obj, $obj);
+testIt('array', $obj);
 testIt('array', '');
 testIt('array', 'a');
 testIt('array', '1');