Conflict dialog improvements

[susnux]

Originally reported by @marcoambrosini in nextcloud/server#50746

---

Team, I would suggest some improvements for this popup, as for me it is not so immediate which checkbox to select.
Things I would do to start improving it are:

1. To emphasize more the question "Which files do you want to keep?" instead of the path which is not so relevant.
   2.Once the new file is selected, change the button label to "Overwrite" or "replace".

Looping @tobiasKaminsky since the mobile version is similar.

Additional points:

• We could also put the "If you select ... be overwritten." text into an info callout component.
• Title of the dialog could be "[n] file conflicts, which files do you want to keep?"
• The path could be in a simple p element just above the callout

[kra-mo]

I have recently encountered this dialog and was also rather confused by it, especially because of its order: the "old" file is to the right, which in a LTR layout can be confusing.

Generally, there are also too many controls and there is too much text in here.

I have been told that this dialog was inspired by OneDrive, but they no longer have a similar dialog, opting instead for toasts only.

Could I take a look at how we could maybe improve it based on this feedback and generally? @marcoambrosini, @jancborchardt

[jancborchardt]

@kra-mo yep, would be good to check out what we can improve here! (Just for the record, it was inspired by Windows files rather than OneDrive – something generally more people use. :)

[kra-mo]

something generally more people use

True, but also something that was designed in the 90s and whose design Microsoft doesn't dare touch anymore :D

[skjnldsv]

I'd like to also point out that our users are used to it by now. As this can lead to destructive behaviour, we should stay careful about how to change.
E.g, switching old and new order could lead to confusion amongst our users and replace the wrong files :)

[kra-mo]

Of course, I was thinking both about broader changes and making it more obvious which is which regardless :)

[kra-mo]

I made a mockup of what could be done with some quick reshuffling:

I agree with the proposed label changes as well, but I don't think we have to show the path at all. It is a modal, so it is relatively contextual already, and people should know where they are when uploading.

[kra-mo]

I would also like if we could drop the "Select all" table header altogether if there is only one file as it is redundant.

[susnux]

and people should know where they are when uploading.

Not necessary as the conflict could happen like 3 levels deep in the folder structure.

But I like the simpler dialog in general :)

[kra-mo]

Hmm, I see, I'll see how to present it then :)

[susnux]

But I also agree with you that it is not the most important information, so maybe replace "at this location" with "at {path}" when not in the root?