From 6262c98fefdfd61f97d5307d7470da08b9330047 Mon Sep 17 00:00:00 2001 From: Mauro Mura Date: Fri, 5 Dec 2025 13:38:06 +0100 Subject: [PATCH 1/2] Handle null cacheKey in cache removal --- lib/private/Collaboration/Reference/ReferenceManager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/private/Collaboration/Reference/ReferenceManager.php b/lib/private/Collaboration/Reference/ReferenceManager.php index 9287b66b2a230..66f7c0436cc82 100644 --- a/lib/private/Collaboration/Reference/ReferenceManager.php +++ b/lib/private/Collaboration/Reference/ReferenceManager.php @@ -172,7 +172,7 @@ public function invalidateCache(string $cachePrefix, ?string $cacheKey = null): return; } - $this->cache->remove(md5($cachePrefix) . '-' . md5($cacheKey)); + $this->cache->remove(md5($cachePrefix) . '-' . md5($cacheKey ?? '')); } /** From 4b060519e0ff5e31a65013960e389080de9d7af4 Mon Sep 17 00:00:00 2001 From: Mauro Mura Date: Thu, 11 Dec 2025 08:37:21 +0100 Subject: [PATCH 2/2] Clarify cache entry removal in ReferenceManager Add comment to clarify cache entry removal process. --- lib/private/Collaboration/Reference/ReferenceManager.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/private/Collaboration/Reference/ReferenceManager.php b/lib/private/Collaboration/Reference/ReferenceManager.php index 66f7c0436cc82..1dad5415ed03f 100644 --- a/lib/private/Collaboration/Reference/ReferenceManager.php +++ b/lib/private/Collaboration/Reference/ReferenceManager.php @@ -172,6 +172,7 @@ public function invalidateCache(string $cachePrefix, ?string $cacheKey = null): return; } + // remove specific cache entry; using ($cacheKey ?? '') avoids md5(null) warnings and ensures stable hashing $this->cache->remove(md5($cachePrefix) . '-' . md5($cacheKey ?? '')); }