Skip to content

Commit 29d9595

Browse files
committed
fix: replace crate::net::resolver with ngx::async_::resolver
ngx's resolver started as this crate's resolver, and includes bug fixes
1 parent fda230c commit 29d9595

File tree

6 files changed

+16
-216
lines changed

6 files changed

+16
-216
lines changed

Cargo.lock

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,10 @@ thiserror = { version = "2.0.12", default-features = false }
3232
zeroize = "1.8.1"
3333

3434
[dependencies.nginx-sys]
35-
git = "https://github.com/nginx/ngx-rust"
36-
rev = "ac60b788cc1b9e9d5e2e92058b54494dcecb1109"
35+
version = "0.5.0-beta"
3736

3837
[dependencies.ngx]
39-
git = "https://github.com/nginx/ngx-rust"
40-
rev = "ac60b788cc1b9e9d5e2e92058b54494dcecb1109"
38+
version = "0.5.0-beta"
4139
default-features = false
4240
features = ["async", "serde", "std"]
4341

@@ -52,3 +50,8 @@ export-modules = []
5250
[profile.release]
5351
codegen-units = 1
5452
lto = true
53+
54+
[patch.crates-io]
55+
ngx = { git = "https://github.com/pchickey/ngx-rust", rev = "75add6c437603faf559712f7c687c58cbb307cf0" }
56+
nginx-sys = { git = "https://github.com/pchickey/ngx-rust", rev = "75add6c437603faf559712f7c687c58cbb307cf0" }
57+

src/net.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,3 @@
66
pub mod connection;
77
pub mod http;
88
pub mod peer_conn;
9-
pub mod resolver;

src/net/http.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ use http_body::Body;
1515
use http_body_util::BodyExt;
1616
use nginx_sys::{ngx_log_t, ngx_resolver_t, NGX_LOG_WARN};
1717
use ngx::allocator::Box;
18+
use ngx::async_::resolver::Resolver;
1819
use ngx::async_::spawn;
1920
use ngx::ngx_log_error;
2021
use thiserror::Error;
2122

2223
use super::peer_conn::PeerConnection;
23-
use super::resolver::Resolver;
2424
use crate::conf::ssl::NgxSsl;
2525

2626
// The largest response we can reasonably expect is a certificate chain, which should not exceed
@@ -65,7 +65,7 @@ pub enum HttpClientError {
6565
#[error("request error: {0}")]
6666
Http(#[from] hyper::Error),
6767
#[error("name resolution error: {0}")]
68-
Resolver(super::resolver::Error),
68+
Resolver(ngx::async_::resolver::Error),
6969
#[error("connection error: {0}")]
7070
Io(io::Error),
7171
#[error("invalid uri: {0}")]
@@ -74,7 +74,7 @@ pub enum HttpClientError {
7474

7575
impl From<io::Error> for HttpClientError {
7676
fn from(err: io::Error) -> Self {
77-
match err.downcast::<super::resolver::Error>() {
77+
match err.downcast::<ngx::async_::resolver::Error>() {
7878
Ok(x) => Self::Resolver(x),
7979
Err(x) => Self::Io(x),
8080
}

src/net/peer_conn.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ use nginx_sys::{
1717
ngx_ssl_shutdown, ngx_ssl_t, ngx_str_t, ngx_url_t, NGX_DEFAULT_POOL_SIZE, NGX_LOG_ERR,
1818
NGX_LOG_WARN,
1919
};
20+
use ngx::async_::resolver::Resolver;
2021
use ngx::collections::Vec;
2122
use ngx::core::Status;
2223
use ngx::{ngx_log_debug, ngx_log_error};
2324
use openssl_sys::{SSL_get_verify_result, X509_verify_cert_error_string, X509_V_OK};
2425

2526
use super::connection::{Connection, ConnectionLogError};
26-
use super::resolver::Resolver;
2727
use crate::util::OwnedPool;
2828

2929
const ACME_DEFAULT_READ_TIMEOUT: ngx_msec_t = 60000;

src/net/resolver.rs

Lines changed: 0 additions & 203 deletions
This file was deleted.

0 commit comments

Comments
 (0)