Add additional type checks and tests

Author: Nicolas Oelgart

src/nicoSWD/Rules/Core/Functions/ParseFloat.php

@@ -11,11 +11,19 @@
 
 use nicoSWD\Rules\Core\CallableFunction;
 use nicoSWD\Rules\Tokens\TokenFloat;
+use nicoSWD\Rules\Tokens\TokenInteger;
 
 final class ParseFloat extends CallableFunction
 {
+    /**
+     * {@inheritdoc}
+     */
     public function call($value = null) : TokenFloat
     {
+        if ($value === null) {
+            return new TokenFloat(NAN);
+        }
+
         return new TokenFloat(
             (float) $value->getValue(),
             $this->token->getOffset(),

src/nicoSWD/Rules/Core/Functions/ParseInt.php

@@ -14,8 +14,15 @@
 
 final class ParseInt extends CallableFunction
 {
+    /**
+     * {@inheritdoc}
+     */
     public function call($value = null) : TokenInteger
     {
+        if ($value === null) {
+            return new TokenInteger(NAN);
+        }
+
         return new TokenInteger(
             (int) $value->getValue(),
             $this->token->getOffset(),

tests/functions/ParseFloatTest.php

@@ -31,4 +31,9 @@ public function testOnUserDefinedVariable()
         $this->assertTrue($this->evaluate('parseFloat(foo) === 3.4', ['foo' => '3.4']));
         $this->assertFalse($this->evaluate('parseFloat(foo) === "3.5"', ['foo' => 3.5]));
     }
+
+    public function testCallWithoutArgsShouldReturnNaN()
+    {
+        $this->assertFalse($this->evaluate('parseFloat() === 1'));
+    }
 }

tests/functions/ParseIntTest.php

@@ -31,4 +31,9 @@ public function testOnUserDefinedVariable()
         $this->assertTrue($this->evaluate('parseInt(foo) === 3', ['foo' => '3']));
         $this->assertFalse($this->evaluate('parseInt(foo) === "3"', ['foo' => 3]));
     }
+
+    public function testCallWithoutArgsShouldReturnNan()
+    {
+        $this->assertFalse($this->evaluate('parseInt() === 1'));
+    }
 }