Re-enable OUTER JOIN tests as this is supported since FirebirdSQL#1238

niekschoemaker · niekschoemaker · commit 51d7dd240586 · 2025-11-28T16:35:19.000+01:00
diff --git a/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/Navigations/NavigationsCollectionFbTest.cs b/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/Navigations/NavigationsCollectionFbTest.cs
@@ -32,12 +32,4 @@ public NavigationsCollectionFbTest(NavigationsFbFixture fixture, ITestOutputHelp
 		Fixture.TestSqlLoggerFactory.Clear();
 		Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
 	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Distinct_projected(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Distinct_projected(queryTrackingBehavior);
-	}
 }
diff --git a/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/Navigations/NavigationsProjectionFbTest.cs b/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/Navigations/NavigationsProjectionFbTest.cs
@@ -31,20 +31,4 @@ public NavigationsProjectionFbTest(NavigationsFbFixture fixture, ITestOutputHelp
 		Fixture.TestSqlLoggerFactory.Clear();
 		Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
 	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Select_subquery_optional_related_FirstOrDefault(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Select_subquery_optional_related_FirstOrDefault(queryTrackingBehavior);
-	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Select_subquery_required_related_FirstOrDefault(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Select_subquery_required_related_FirstOrDefault(queryTrackingBehavior);
-	}
 }
diff --git a/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsCollectionFbTest.cs b/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsCollectionFbTest.cs
@@ -31,12 +31,4 @@ public OwnedNavigationsCollectionFbTest(OwnedNavigationsFbFixture fixture, ITest
 		Fixture.TestSqlLoggerFactory.Clear();
 		Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
 	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Distinct_projected(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Distinct_projected(queryTrackingBehavior);
-	}
 }
diff --git a/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsProjectionFbTest.cs b/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsProjectionFbTest.cs
@@ -31,20 +31,4 @@ public OwnedNavigationsProjectionFbTest(OwnedNavigationsFbFixture fixture, ITest
 		Fixture.TestSqlLoggerFactory.Clear();
 		Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
 	}
-
-	// Uses OUTER JOIN
-	[NotSupportedOnFirebirdTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Select_subquery_optional_related_FirstOrDefault(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Select_subquery_optional_related_FirstOrDefault(queryTrackingBehavior);
-	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Select_subquery_required_related_FirstOrDefault(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Select_subquery_required_related_FirstOrDefault(queryTrackingBehavior);
-	}
 }
diff --git a/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsSetOperationsFbTest.cs b/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsSetOperationsFbTest.cs
@@ -31,12 +31,4 @@ public OwnedNavigationsSetOperationsFbTest(OwnedNavigationsFbFixture fixture, IT
 		Fixture.TestSqlLoggerFactory.Clear();
 		Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
 	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Over_associate_collection_projected(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Over_associate_collection_projected(queryTrackingBehavior);
-	}
 }
diff --git a/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedTableSplitting/OwnedTableSplittingProjectionFbTest.cs b/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Associations/OwnedTableSplitting/OwnedTableSplittingProjectionFbTest.cs
@@ -31,20 +31,4 @@ public OwnedTableSplittingProjectionFbTest(OwnedTableSplittingFbFixture fixture,
 		Fixture.TestSqlLoggerFactory.Clear();
 		Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
 	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Select_subquery_optional_related_FirstOrDefault(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Select_subquery_optional_related_FirstOrDefault(queryTrackingBehavior);
-	}
-
-	// Uses OUTER JOIN
-	[NotSupportedByProviderTheory]
-	[MemberData(nameof(TrackingData))]
-	public override Task Select_subquery_required_related_FirstOrDefault(QueryTrackingBehavior queryTrackingBehavior)
-	{
-		return base.Select_subquery_required_related_FirstOrDefault(queryTrackingBehavior);
-	}
 }
diff --git a/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/PrimitiveCollectionsQueryFbTest.cs b/src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/PrimitiveCollectionsQueryFbTest.cs
@@ -476,13 +476,6 @@ public override Task Project_empty_collection_of_nullables_and_collection_only_c
 		return base.Project_empty_collection_of_nullables_and_collection_only_containing_nulls();
 	}
 
-	// Uses OUTER JOIN
-	[NotSupportedByProviderFact]
-	public override Task Project_inline_collection_with_Union()
-	{
-		return base.Project_inline_collection_with_Union();
-	}
-
 	[NotSupportedByProviderFact]
 	public override Task Project_multiple_collections()
 	{

Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,4 @@ public NavigationsCollectionFbTest(NavigationsFbFixture fixture, ITestOutputHelp`
`32`	`32`	`Fixture.TestSqlLoggerFactory.Clear();`
`33`	`33`	`Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);`
`34`	`34`	`}`
`35`		`-`
`36`		`- // Uses OUTER JOIN`
`37`		`- [NotSupportedByProviderTheory]`
`38`		`- [MemberData(nameof(TrackingData))]`
`39`		`- public override Task Distinct_projected(QueryTrackingBehavior queryTrackingBehavior)`
`40`		`- {`
`41`		`- return base.Distinct_projected(queryTrackingBehavior);`
`42`		`- }`
`43`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,12 +31,4 @@ public OwnedNavigationsCollectionFbTest(OwnedNavigationsFbFixture fixture, ITest`
`31`	`31`	`Fixture.TestSqlLoggerFactory.Clear();`
`32`	`32`	`Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);`
`33`	`33`	`}`
`34`		`-`
`35`		`- // Uses OUTER JOIN`
`36`		`- [NotSupportedByProviderTheory]`
`37`		`- [MemberData(nameof(TrackingData))]`
`38`		`- public override Task Distinct_projected(QueryTrackingBehavior queryTrackingBehavior)`
`39`		`- {`
`40`		`- return base.Distinct_projected(queryTrackingBehavior);`
`41`		`- }`
`42`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -476,13 +476,6 @@ public override Task Project_empty_collection_of_nullables_and_collection_only_c`
`476`	`476`	`return base.Project_empty_collection_of_nullables_and_collection_only_containing_nulls();`
`477`	`477`	`}`
`478`	`478`
`479`		`- // Uses OUTER JOIN`
`480`		`- [NotSupportedByProviderFact]`
`481`		`- public override Task Project_inline_collection_with_Union()`
`482`		`- {`
`483`		`- return base.Project_inline_collection_with_Union();`
`484`		`- }`
`485`		`-`
`486`	`479`	`[NotSupportedByProviderFact]`
`487`	`480`	`public override Task Project_multiple_collections()`
`488`	`481`	`{`