Make sure Mist has the correct volume when creating disk images

[wakco]

🪲 Description

mist-cli fails to properly track what volumes it has mounted, causing mist-cli to attempt to manage volumes it didn't mount. i.e. mist-cli attempts to manage USB sticks already created as macOS installers that happen to be mounted, instead of the volumes it mounted when attempting to create image and iso installers.

📋 Steps to Reproduce

1. connect a USB stick that is already a bootable volume installer
2. use mist to download an installer for the same macOS major version of types image or iso
3. Observe errors as it is unable to do anything with the disk image it thought it copied the installer files to (which turned out to be the USB stick and not the .cdr file it had initially created).

✅ Expected Behaviour

Mist should be tracking the volume path that is created when mounting volumes, so that it copies and manages the correct volumes.

💻 Environment

• mist version (mist --version): 2.0 (latest: 2.0)
• macOS Version (sw_vers): N/A, observed on both macOS Sonoma and macOS Ventura (which along with the issue also makes the hardware information N/A)

ℹ️ Additional context

• Is this also a bug in Mist.app? Unknown.
  • No idea, I only using the command line version

[ninxsoft]

@wakco I suspect this is the culprit:

mist-cli/Mist/Helpers/Generator.swift

Line 402 in d5715b1

arguments += ["--volume", installer.temporaryISOMountPointURL.path, "--nointeraction"]

When attempting to run createinstallmedia, I am passing in the wrong --volume option - this should be the target volume that was specified with via --bootable-installer-volume option, and not the internal temporaryISOMountPointURL value.

I'll have a fix soon, which should also resolve #175 and #179 👍