[BUG] typos_lsp: settings are not applied correctly

[demenik]

Plugin

lsp

Nixpkgs Release

unstable

Home Manager Release

unstable

I have read the FAQ

• I have read the FAQ and my bug is not listed there.

Description

I tried changing the diagnostic severity of typos_lsp (see typos_lsp docs) using the init_options.diagnosticSeverity option. Nixvim only allows me to put that in plugins.lsp.servers.typos_lsp.settings, which results in the following init.lua code:

-- ...
local __lspServers = {
  -- ...
  { extraOptions = { settings = { init_options = { diagnosticSeverity = "Info" } } }, name = "typos_lsp" },
  -- ...
}
-- ...

This doesn't work, because the value of extraOptions is getting passed to require("lspconfig")[server.name].setup(options). That means the options in setup look like { settings = { init_options = { ... } } } while they have to look like { init_options = { ... } }.

Minimal, Reproducible Example (MRE)

programs.nixvim.plugins.lsp.servers.typos_lsp = {
  enable = true;
  settings.init_options.diagnosticSeverity = "Hint";
};

[saygo-png]

You are using the old lsp module. We have plugins.lsp and top level lsp. The new one handles this correctly. If you were to use that one the MRE would look like this and it would not have this issue:

programs.nixvim = {
  plugins.lspconfig.enable = true;
  lsp.servers.typos_lsp = {
    enable = true;
    settings.init_options.diagnosticSeverity = "Hint";
  };
};

[saygo-png]

I'll keep this open since this is still a bug in the old module which isn't yet officially deprecated.