Require Node.js 12.20 and support typed arrays

Author: Richienb

package.json

@@ -11,7 +11,7 @@
 		"dist"
 	],
 	"engines": {
-		"node": ">=12"
+		"node": ">=12.20"
 	},
 	"scripts": {
 		"build": "tsc",
@@ -31,12 +31,14 @@
 	"dependencies": {
 		"cheerio": "^1.0.0-rc.10",
 		"content-type": "^1.0.4",
-		"iconv-lite": "^0.6.3"
+		"iconv-lite": "^0.6.3",
+		"type-fest": "^2.0.0"
 	},
 	"devDependencies": {
 		"@richienb/tsconfig": "^0.3.0",
 		"@types/cheerio": "^0.22.30",
 		"@types/content-type": "^1.1.5",
+		"@types/node": "^16.4.13",
 		"ava": "^3.15.0",
 		"node-fetch": "3.0.0-beta.10",
 		"ts-node": "^10.1.0",

readme.md

@@ -22,7 +22,7 @@ convertBody(content);
 
 #### content
 
-Type: [`Buffer`](https://nodejs.org/api/buffer.html#buffer_class_buffer)
+Type: [`Buffer`](https://nodejs.org/api/buffer.html#buffer_class_buffer) | [`TypedArray`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Typed_arrays)
 
 The content to stringify.
 

source/index.ts

@@ -1,5 +1,6 @@
-import type {Buffer} from 'node:buffer';
+import {Buffer} from 'node:buffer';
 import iconv from 'iconv-lite';
+import type {TypedArray} from 'type-fest';
 import getCharset from './utils/get-charset.js';
 
 /**
@@ -15,10 +16,14 @@ import convertBody from 'fetch-charset-detection';
 convertBody(content);
 ```
 */
-export default function convertBody(content: Buffer, headers?: Headers): string {
+export default function convertBody(content: Buffer | ArrayBuffer | SharedArrayBuffer | TypedArray, headers?: Headers): string {
+	if (!Buffer.isBuffer(content)) {
+		content = Buffer.from(content);
+	}
+
 	// Turn raw buffers into a single utf-8 buffer
 	return iconv.decode(
-		content,
-		getCharset(content, headers),
+		content as Buffer,
+		getCharset(content as Buffer, headers),
 	);
 }

test.ts

@@ -1,8 +1,11 @@
+import type {Buffer} from 'node:buffer';
 import test from 'ava';
 import {Headers} from 'node-fetch';
 import iconv from 'iconv-lite';
 import convertBody from './source/index.js';
 
+const toArrayBuffer = (buffer: Buffer): ArrayBuffer => buffer.buffer.slice(0, buffer.byteLength);
+
 test('should support encoding decode, xml dtd detect', t => {
 	const text = '<?xml version="1.0" encoding="EUC-JP"?><title>日本語</title>';
 	t.is(convertBody(iconv.encode(text, 'EUC-JP'), new Headers({'Content-Type': 'text/xml'})), text);
@@ -39,3 +42,8 @@ test('should only do encoding detection up to 1024 bytes', t => {
 	const padding = 'a'.repeat(1200);
 	t.not(convertBody(iconv.encode(padding + text, 'gbk'), new Headers({'Content-Type': 'text/html', 'Transfer-Encoding': 'chunked'})), text);
 });
+
+test('should support typed arrays', t => {
+	const text = '<div>日本語</div>';
+	t.is(convertBody(toArrayBuffer(iconv.encode(text, 'Shift_JIS')), new Headers({'Content-Type': 'text/html; charset=Shift-JIS'})), text);
+});