From d9c37fe1e67f36d8e993a3b1e7089a27a01671be Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Thu, 16 Oct 2025 13:49:35 +0200 Subject: [PATCH] tools: fix inspector_protocol updater `.github/workflows/tools.yml` creates a temp file `temp-output` in the workspace, which fails `git status` clean repo check. Also, the GHA checks out a new branch after the update script. Removes these checks in the `roll.py` to fix its run on the GHA. --- tools/inspector_protocol/roll.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tools/inspector_protocol/roll.py b/tools/inspector_protocol/roll.py index 396dd2c029d2ea..92a68d4aa093e4 100644 --- a/tools/inspector_protocol/roll.py +++ b/tools/inspector_protocol/roll.py @@ -47,13 +47,6 @@ def CheckRepoIsClean(path): raise Exception('%s is not a clean git repo (run git status)' % path) -def CheckRepoIsNotAtMainBranch(path): - os.chdir(path) - stdout = RunCmd(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip() - if stdout == 'main': - raise Exception('%s is at main branch - refusing to copy there.' % path) - - def CheckRepoIsInspectorProtocolCheckout(path): os.chdir(path) revision = RunCmd(['git', 'config', '--get', 'remote.origin.url']).strip() @@ -123,12 +116,7 @@ def main(argv): downstream = os.path.normpath(os.path.expanduser( args.node_src_downstream)) CheckRepoIsClean(upstream) - CheckRepoIsClean(downstream) CheckRepoIsInspectorProtocolCheckout(upstream) - # Check that the destination Git repo isn't at the main branch - it's - # generally a bad idea to check into the main branch, so we catch this - # common pilot error here early. - CheckRepoIsNotAtMainBranch(downstream) # Read V8's inspector_protocol revision v8_ip_revision = ReadV8IPRevision(downstream)