Code refactoring - removed logging

Author: nomemory

build.gradle

@@ -27,7 +27,6 @@ repositories {
 
 dependencies {
 
-    compile group: 'org.slf4j', name: 'slf4j-api', version: '1.7.30'
     compile group: 'org.apache.commons', name: 'commons-lang3', version: '3.11'
     compile group: 'org.apache.commons', name: 'commons-text', version: '1.9'
     compile group: 'commons-codec', name: 'commons-codec', version: '1.15'

src/main/java/net/andreinc/mockneat/unit/text/Markovs.java

@@ -6,8 +6,6 @@
 import net.andreinc.mockneat.abstraction.MockUnitString;
 import net.andreinc.mockneat.types.enums.MarkovChainType;
 import net.andreinc.mockneat.utils.file.FileManager;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.io.UncheckedIOException;
@@ -25,8 +23,6 @@ public class Markovs extends MockUnitBase implements MockUnitString {
 
     private static final FileManager fm = FileManager.getInstance();
 
-    private static final Logger logger = LoggerFactory.getLogger(Markovs.class);
-
     private final Map<MarkovChainType, MChainText> markovUnits =  new EnumMap<>(MarkovChainType.class);
 
     private int size = 512;
@@ -50,7 +46,6 @@ protected Markovs() {}
 
     private MChainText get(MarkovChainType markovChainType) throws IOException {
         if (!markovUnits.containsKey(markovChainType)) {
-            logger.info("Loading MarkovUnit in memory '{}'." , markovChainType.getFile());
             MChainText mChainText = new MChainText(2, mockNeat.getRandom());
             List<String> lines = fm.read(markovChainType);
             mChainText.train(lines);
@@ -86,7 +81,6 @@ public MockUnitString type(MarkovChainType type) {
                 unit = get(type);
                 return unit.generateText(size);
             } catch (IOException e) {
-                logger.error("Cannot load MarkovUnit chain of type '{}'.", type.name());
                 throw new UncheckedIOException(e);
             }
         };

src/main/java/net/andreinc/mockneat/utils/LoopsUtils.java

@@ -2,17 +2,13 @@
 
 import net.andreinc.mockneat.MockNeat;
 import net.andreinc.mockneat.types.CallBack;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.util.Arrays;
 import java.util.function.Consumer;
 import java.util.function.Function;
 
 public final class LoopsUtils {
 
-    private static final Logger logger = LoggerFactory.getLogger(LoopsUtils.class);
-
     private LoopsUtils() {}
 
     public static void loop(int cycles, CallBack callBack) {
@@ -26,17 +22,16 @@ public static void loop(int cycles, MockNeat[] array, Consumer<MockNeat> consume
     }
 
     public static <T> void loop(int cycles, MockNeat[] array, Function<MockNeat, T> map, Consumer<T> consume) {
-        loop(cycles, () -> Arrays.stream(array).map(map).forEach(consume));
+        loop(cycles, () -> Arrays.stream(array)
+                                    .map(map)
+                                    .forEach(consume));
     }
 
     public static <T> void loop(boolean dbg, int cycles, MockNeat[] array, Function<MockNeat, T> map, Consumer<T> consume) {
         loop(cycles,
                 () -> Arrays.stream(array)
                         .map(r -> {
                             T o = map.apply(r);
-                            if (dbg) {
-                                logger.info(null == o ? "" : o.toString());
-                            }
                             return o;
                         })
                         .forEach(consume));

src/main/java/net/andreinc/mockneat/utils/file/FileManager.java

@@ -2,8 +2,6 @@
 
 import net.andreinc.mockneat.types.enums.DictType;
 import net.andreinc.mockneat.types.enums.MarkovChainType;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import java.io.BufferedReader;
 import java.io.IOException;
@@ -21,8 +19,6 @@
 
 public class FileManager {
 
-    private static final Logger logger = LoggerFactory.getLogger(FileManager.class);
-
     private static final String DICT_FOLDER = "dicts/";
 
     private static final String MARKOV_FOLDER = "markov/";
@@ -52,10 +48,8 @@ public List<String> getLines(String path) {
         if (!JAR_EXTERNAL.containsKey(path)) {
             try {
                 List<String> lines = read(path);
-                logger.info("Loaded file '{}' in memory. The file contains {} lines.", path, lines.size());
                 JAR_EXTERNAL.put(path, lines);
             } catch (IOException e) {
-                logger.error("Cannot read file '{}' in memory.", path);
                throw new IllegalArgumentException(e);
             }
         }
@@ -67,13 +61,8 @@ public List<String> getLines(DictType dictType) {
         if (!JAR_INTERNAL.containsKey(internal)) {
             try {
                 List<String> lines = read(dictType);
-                logger.info("Loading internal dictionary '{}' in memory. The dictionary contains {} lines.",
-                        dictType.getFile(),
-                        lines.size());
                 JAR_INTERNAL.put(internal, lines);
             } catch (IOException e) {
-                logger.error("Cannot read internal dictionary '{}' in memory. Something is terribly wrong.",
-                        dictType.getFile());
                 throw new UncheckedIOException(e);
             }
         }

src/main/resources/log4j.properties

@@ -74,7 +74,6 @@ public void testValuesWithMockUnits2() {
                                     .add(0.1, mockNeat.ints().range(5, 6))
                                     .val(),
                 val -> {
-                    System.out.println(val);
                     Assert.assertTrue(val >= 0 && val <= 5);
                 }
         );