Skip to content

Commit 348e20e

Browse files
matter: Fix Kconfig compliance
Fixed several Zephyr guidelines compliance issues in Matter. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
1 parent c1fa3cd commit 348e20e

File tree

9 files changed

+65
-66
lines changed

9 files changed

+65
-66
lines changed

applications/matter_bridge/Kconfig

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,18 @@ choice BRIDGED_DEVICE_IMPLEMENTATION
3333
prompt "Bridged Device implementation"
3434
default BRIDGED_DEVICE_SIMULATED
3535

36-
config BRIDGED_DEVICE_SIMULATED
37-
bool "Simulated Bridged Device"
38-
help
39-
Enables using simulated bridged devices that do not perform
40-
real operations, but emulate exemplary data to imitate the real
41-
device behavior.
42-
43-
config BRIDGED_DEVICE_BT
44-
bool "Bluetooth LE Bridged Device"
45-
help
46-
Enables using real bridged devices that communicate with the Matter bridge device
47-
over Bluetooth LE.
36+
config BRIDGED_DEVICE_SIMULATED
37+
bool "Simulated Bridged Device"
38+
help
39+
Enables using simulated bridged devices that do not perform
40+
real operations, but emulate exemplary data to imitate the real
41+
device behavior.
42+
43+
config BRIDGED_DEVICE_BT
44+
bool "Bluetooth LE Bridged Device"
45+
help
46+
Enables using real bridged devices that communicate with the Matter bridge device
47+
over Bluetooth LE.
4848

4949
endchoice
5050

@@ -54,17 +54,17 @@ choice BRIDGED_DEVICE_SIMULATED_ONOFF_IMPLEMENTATION
5454
prompt "Simulated bridged onoff device implementation"
5555
default BRIDGED_DEVICE_SIMULATED_ONOFF_SHELL
5656

57-
config BRIDGED_DEVICE_SIMULATED_ONOFF_AUTOMATIC
58-
bool "Automatically simulated bridged onoff device"
59-
help
60-
Enables using simulated bridged onoff device that
61-
automatically changes its state periodically.
57+
config BRIDGED_DEVICE_SIMULATED_ONOFF_AUTOMATIC
58+
bool "Automatically simulated bridged onoff device"
59+
help
60+
Enables using simulated bridged onoff device that
61+
automatically changes its state periodically.
6262

63-
config BRIDGED_DEVICE_SIMULATED_ONOFF_SHELL
64-
bool "Shell controlled simulated bridged onoff device"
65-
help
66-
Enables using simulated bridged onoff device that is
67-
controlled by shell commands.
63+
config BRIDGED_DEVICE_SIMULATED_ONOFF_SHELL
64+
bool "Shell controlled simulated bridged onoff device"
65+
help
66+
Enables using simulated bridged onoff device that is
67+
controlled by shell commands.
6868

6969
endchoice
7070

@@ -160,8 +160,7 @@ config NCS_SAMPLE_MATTER_PERSISTENT_STORAGE
160160
default y
161161

162162
config BRIDGE_SMART_PLUG_SUPPORT
163-
bool "Enables additional endpoint implementing Matter smart plug functionality"
164-
default n
163+
bool "Additional endpoint implementing Matter smart plug functionality"
165164

166165
# Sample configuration used for Thread networking
167166
if OPENTHREAD

samples/matter/common/src/Kconfig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ config NCS_SAMPLE_MATTER_CUSTOM_BLUETOOTH_ADVERTISING
2525
allow to use the custom one.
2626

2727
config NCS_SAMPLE_MATTER_OPERATIONAL_KEYS_MIGRATION_TO_ITS
28-
bool "Enable operational keys migration feature"
28+
bool "Operational keys migration feature"
2929
depends on CHIP_CRYPTO_PSA
3030
help
3131
Enables migration of the operational keys stored in the persistent storage to the PSA ITS secure storage.
@@ -41,7 +41,7 @@ config NCS_SAMPLE_MATTER_FACTORY_RESET_ON_KEY_MIGRATION_FAILURE
4141
properly to PSA ITS storage.
4242

4343
config NCS_SAMPLE_MATTER_LEDS
44-
bool "Enable LEDs usage"
44+
bool "LEDs usage"
4545
default y
4646
depends on DK_LIBRARY
4747
help
@@ -108,7 +108,7 @@ config NCS_SAMPLE_MATTER_ZAP_FILE_PATH
108108
It shall contain the file name and .zap extension.
109109

110110
config NCS_SAMPLE_MATTER_CERTIFICATION
111-
bool "Enable patches required for Matter platform certification"
111+
bool "Patches for Matter platform certification"
112112
help
113113
It enables including software patches required for the Matter platform certification
114114
purposes. Currently it works only with the Matter template sample.

samples/matter/common/src/bridge/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ config BRIDGE_AGGREGATOR_ENDPOINT_ID
2121
default 1
2222

2323
config BRIDGE_MIGRATE_PRE_2_7_0
24-
bool "Enable migration of bridged device data stored in old scheme from pre nRF SDK 2.7.0 releases"
24+
bool "Migration of bridged device data stored in old scheme from pre nRF SDK 2.7.0 releases"
2525

2626
config BRIDGE_MIGRATE_VERSION_1
27-
bool "Enable migration of bridged device data stored in version 1 of new scheme"
27+
bool "Migration of bridged device data stored in version 1 of new scheme"
2828
default y
2929

3030
if BRIDGED_DEVICE_BT

samples/matter/common/src/diagnostic/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#
66

77
menuconfig NCS_SAMPLE_MATTER_DIAGNOSTIC_LOGS
8-
bool "Enable diagnostics logs support"
8+
bool "Diagnostics logs support"
99
imply CHIP_ENABLE_BDX_LOG_TRANSFER
1010
help
1111
Provides support for diagnostics logs. Diagnostics logs allow the Matter controller to read end-user,

samples/matter/common/src/watchdog/Kconfig

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -11,47 +11,47 @@ menuconfig NCS_SAMPLE_MATTER_WATCHDOG
1111
if NCS_SAMPLE_MATTER_WATCHDOG
1212

1313
config NCS_SAMPLE_MATTER_WATCHDOG_PAUSE_IN_SLEEP
14-
bool "Pause watchdog while CPU is in sleep state"
15-
help
16-
If enabled, the watchdog will be paused while the CPU is in idle (sleep) state.
14+
bool "Pause watchdog while CPU is in sleep state"
15+
help
16+
If enabled, the watchdog will be paused while the CPU is in idle (sleep) state.
1717

1818
config NCS_SAMPLE_MATTER_WATCHDOG_PAUSE_ON_DEBUG
19-
bool "Pause watchdog while the CPU is halted by the debugger"
20-
default y
21-
help
22-
If disabled, the watchdog will not be paused while the CPU is halted by the debugger and
23-
the device reset will be triggered, if the feeding signal is not received within the
24-
specified time.
19+
bool "Pause watchdog while the CPU is halted by the debugger"
20+
default y
21+
help
22+
If disabled, the watchdog will not be paused while the CPU is halted by the debugger and
23+
the device reset will be triggered, if the feeding signal is not received within the
24+
specified time.
2525

2626
config NCS_SAMPLE_MATTER_WATCHDOG_DEFAULT
27-
bool "Use watchdog object dedicated for Main and Matter threads"
28-
default y
29-
help
30-
The default watchdog objects are created in the matter_init.cpp file.
31-
The watchdog objects are dedicated for Main and Matter threads and are initialized
32-
using the NCS_SAMPLE_MATTER_WATCHDOG_DEFAULT_FEED_TIME value.
27+
bool "Use watchdog object dedicated for Main and Matter threads"
28+
default y
29+
help
30+
The default watchdog objects are created in the matter_init.cpp file.
31+
The watchdog objects are dedicated for Main and Matter threads and are initialized
32+
using the NCS_SAMPLE_MATTER_WATCHDOG_DEFAULT_FEED_TIME value.
3333

3434
config NCS_SAMPLE_MATTER_WATCHDOG_TIMEOUT
35-
int "Default maximum window time in milliseconds for receiving the feeding signal"
36-
default 600000 # 10 minutes
37-
help
38-
The default maximum window time defines a time within which the feeding signal must be received
39-
from all created Watchdog sources to reset the watchdog object's timer.
40-
If the signals come after elapsing this time, the watchdog timer will not be reset and the
41-
reboot occur.
35+
int "Default maximum window time in milliseconds for receiving the feeding signal"
36+
default 600000 # 10 minutes
37+
help
38+
The default maximum window time defines a time within which the feeding signal must be received
39+
from all created Watchdog sources to reset the watchdog object's timer.
40+
If the signals come after elapsing this time, the watchdog timer will not be reset and the
41+
reboot occur.
4242

4343
config NCS_SAMPLE_MATTER_WATCHDOG_DEFAULT_FEED_TIME
44-
int "Default interval of feeding time in milliseconds"
45-
default 300000 # 5 minutes
46-
help
44+
int "Default interval of feeding time in milliseconds"
45+
default 300000 # 5 minutes
46+
help
4747
The default interval in milliseconds for calling the feeding callback if it exists.
4848

4949
config NCS_SAMPLE_MATTER_WATCHDOG_EVENT_TRIGGERS
50-
bool "Enables default event triggers for watchdog purposes"
51-
default y
52-
depends on NCS_SAMPLE_MATTER_TEST_EVENT_TRIGGERS
53-
help
54-
Enables test event triggers to block Main and Matter stacks for the specific amount of time
55-
and test Watchdog in this way.
50+
bool "Default event triggers for watchdog purposes"
51+
default y
52+
depends on NCS_SAMPLE_MATTER_TEST_EVENT_TRIGGERS
53+
help
54+
Enables test event triggers to block Main and Matter stacks for the specific amount of time
55+
and test Watchdog in this way.
5656

5757
endif # NCS_SAMPLE_MATTER_WATCHDOG

samples/matter/lock/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ config LOCK_MAX_HOLIDAY_SCHEDULES
5353
endif
5454

5555
config LOCK_ENABLE_DEBUG
56-
bool "Enable debug features to print users and credentials"
56+
bool "Debug features to print users and credentials"
5757
depends on SHELL
5858
help
5959
Debug features allows to checking and printing current users, their state, and

samples/openthread/cli/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module-str = ot_cli
1313
source "$(ZEPHYR_BASE)/subsys/logging/Kconfig.template.log_config"
1414

1515
config CLI_SAMPLE_LOW_POWER
16-
bool "Enable low power mode for the CLI sample"
16+
bool "Low power mode for the CLI sample"
1717

1818
config CLI_SAMPLE_MULTIPROTOCOL
19-
bool "Enable multiprotocol for the CLI sample"
19+
bool "Multiprotocol for the CLI sample"

samples/openthread/coprocessor/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ module-str = ot_coprocessor
1313
source "$(ZEPHYR_BASE)/subsys/logging/Kconfig.template.log_config"
1414

1515
config RCP_SAMPLE_HCI
16-
bool "Enable Bluetooth HCI USB support for the coprocessor sample"
16+
bool "Bluetooth HCI USB support for the coprocessor sample"
1717
select EXPERIMENTAL

west.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ manifest:
157157
- name: matter
158158
repo-path: sdk-connectedhomeip
159159
path: modules/lib/matter
160-
revision: 0b6bdd7a8f5836d61a5be36ef4f046387ba9e7e7
160+
revision: 48881b605a42d7b3e1db48a060be4ea7cdd8d65f
161161
west-commands: scripts/west/west-commands.yml
162162
submodules:
163163
- name: nlio

0 commit comments

Comments
 (0)