fix(tooling): skip null and empty arguments

Author: matkoch

source/Nuke.Common.Tests/SettingsTest.cs

@@ -122,6 +122,17 @@ public void TestDotNet()
             "run --property:foo=bar --property:InformationalVersion=version -- arg1 arg2");
     }
 
+    [Fact]
+    public void TestDotNet_Empty()
+    {
+        Assert(new DotNetBuildSettings()
+                .SetFramework(null)
+                .SetConfiguration("")
+                .SetProperty("foo1", null)
+                .SetProperty("foo2", ""),
+            "build");
+    }
+
     [Fact]
     public void TestDocker()
     {

source/Nuke.Tooling/ToolOptions.Arguments.cs

@@ -136,6 +136,9 @@ IEnumerable<string> GetScalarArguments()
                 yield break;
 
             var value = Parse(token, property.PropertyType);
+            if (value.IsNullOrWhiteSpace())
+                yield break;
+
             foreach (var part in formatParts)
                 yield return part.Replace(ValuePlaceholder, value);
         }
@@ -145,7 +148,7 @@ IEnumerable<string> GetListArguments()
             Assert.True(formatParts.Length <= 2);
 
             var valueType = property.PropertyType.GetScalarType();
-            var values = token.Value<JArray>().Select(x => Parse(x, valueType));
+            var values = token.Value<JArray>().Select(x => Parse(x, valueType)).Where(x => !x.IsNullOrWhiteSpace());
 
             if (attribute.Separator == null)
             {
@@ -175,7 +178,8 @@ from part in formatParts
         IEnumerable<string> GetDictionaryArguments()
         {
             var valueType = property.PropertyType.GetGenericArguments().Last();
-            var pairs = token.Value<JObject>().Properties().Select(x => (Key: x.Name, Value: Parse(x, valueType)));
+            var pairs = token.Value<JObject>().Properties().Select(x => (Key: x.Name, Value: Parse(x, valueType)))
+                .Where(x => !x.Value.IsNullOrWhiteSpace());
 
             if (attribute.Separator == null)
             {
@@ -205,7 +209,7 @@ IEnumerable<string> GetLookupArguments()
         {
             var valueType = property.PropertyType.GetGenericArguments().Last();
             var pairs = token.Value<JObject>().Properties()
-                .Select(x => (Key: x.Name, Values: x.Value.Value<JArray>().Select(x => Parse(x, valueType))));
+                .Select(x => (Key: x.Name, Values: x.Value.Value<JArray>().Select(x => Parse(x, valueType)).Where(x => !x.IsNullOrWhiteSpace())));
 
             if (attribute.Separator == null)
             {