Skip to content

Commit 3633f02

Browse files
committed
using same hierarchy of trackers for client shutdown control
1 parent 1dbc76a commit 3633f02

File tree

2 files changed

+11
-13
lines changed
  • common/client-core/src/client/base_client
  • sdk/rust/nym-sdk/src/mixnet

2 files changed

+11
-13
lines changed

common/client-core/src/client/base_client/mod.rs

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@ where
883883
// Create a shutdown tracker for this client - either as a child of provided tracker
884884
// or get one from the registry
885885
let shutdown_tracker = match self.shutdown {
886-
Some(parent_tracker) => parent_tracker.child_tracker(),
886+
Some(parent_tracker) => parent_tracker.clone(),
887887
None => nym_task::get_sdk_shutdown_tracker()?,
888888
};
889889

@@ -917,7 +917,7 @@ where
917917
self.user_agent.clone(),
918918
generate_client_stats_id(*self_address.identity()),
919919
input_sender.clone(),
920-
&shutdown_tracker.child_tracker(),
920+
&shutdown_tracker.clone(),
921921
);
922922

923923
// needs to be started as the first thing to block if required waiting for the gateway
@@ -927,7 +927,7 @@ where
927927
shared_topology_accessor.clone(),
928928
self_address.gateway(),
929929
self.wait_for_gateway,
930-
&shutdown_tracker.child_tracker(),
930+
&shutdown_tracker.clone(),
931931
)
932932
.await?;
933933

@@ -947,15 +947,15 @@ where
947947
stats_reporter.clone(),
948948
#[cfg(unix)]
949949
self.connection_fd_callback,
950-
&shutdown_tracker.child_tracker(),
950+
&shutdown_tracker.clone(),
951951
)
952952
.await?;
953953
let gateway_ws_fd = gateway_transceiver.ws_fd();
954954

955955
let reply_storage = Self::setup_persistent_reply_storage(
956956
reply_storage_backend,
957957
key_rotation_config,
958-
&shutdown_tracker.child_tracker(),
958+
&shutdown_tracker.clone(),
959959
)
960960
.await?;
961961

@@ -966,18 +966,16 @@ where
966966
reply_storage.key_storage(),
967967
reply_controller_sender.clone(),
968968
stats_reporter.clone(),
969-
&shutdown_tracker.child_tracker(),
969+
&shutdown_tracker.clone(),
970970
);
971971

972972
// The message_sender is the transmitter for any component generating sphinx packets
973973
// that are to be sent to the mixnet. They are used by cover traffic stream and real
974974
// traffic stream.
975975
// The MixTrafficController then sends the actual traffic
976976

977-
let (message_sender, client_request_sender) = Self::start_mix_traffic_controller(
978-
gateway_transceiver,
979-
&shutdown_tracker.child_tracker(),
980-
);
977+
let (message_sender, client_request_sender) =
978+
Self::start_mix_traffic_controller(gateway_transceiver, &shutdown_tracker.clone());
981979

982980
// Channels that the websocket listener can use to signal downstream to the real traffic
983981
// controller that connections are closed.
@@ -1006,7 +1004,7 @@ where
10061004
shared_lane_queue_lengths.clone(),
10071005
client_connection_rx,
10081006
stats_reporter.clone(),
1009-
&shutdown_tracker.child_tracker(),
1007+
&shutdown_tracker.clone(),
10101008
);
10111009

10121010
if !self
@@ -1022,7 +1020,7 @@ where
10221020
shared_topology_accessor.clone(),
10231021
message_sender,
10241022
stats_reporter.clone(),
1025-
&shutdown_tracker.child_tracker(),
1023+
&shutdown_tracker.clone(),
10261024
);
10271025
}
10281026

sdk/rust/nym-sdk/src/mixnet/client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ where
762762
client_output,
763763
client_state.clone(),
764764
nym_address,
765-
started_client.shutdown_handle.child_tracker(),
765+
started_client.shutdown_handle.clone(),
766766
packet_type,
767767
);
768768

0 commit comments

Comments
 (0)