[chore] Clippy fix (#6060)

* clippy multiple of fix

* removed dead code?

* huh?

* ci fixes

Author: simonwicky

.github/workflows/ci-build-vpn-api-wasm.yml

@@ -9,7 +9,7 @@ on:
 
 jobs:
   wasm:
-    runs-on: arc-ubuntu-22.04
+    runs-on: arc-linux-latest
     env:
       CARGO_TERM_COLOR: always
       RUSTUP_PERMIT_COPY_RENAME: 1

.github/workflows/ci-nym-wallet-rust.yml

@@ -11,7 +11,7 @@ on:
 
 jobs:
   build:
-    runs-on: arc-ubuntu-22.04
+    runs-on: arc-linux-latest
     env:
       CARGO_TERM_COLOR: always
       RUSTUP_PERMIT_COPY_RENAME: 1

.github/workflows/ci-sdk-wasm.yml

@@ -11,7 +11,7 @@ on:
 
 jobs:
   wasm:
-    runs-on: arc-ubuntu-22.04
+    runs-on: arc-linux-latest
     env:
       CARGO_TERM_COLOR: always
       RUSTUP_PERMIT_COPY_RENAME: 1

Cargo.lock

@@ -47,7 +47,7 @@ impl TryFrom<&[u8]> for SecretKeyAuth {
 
     fn try_from(bytes: &[u8]) -> Result<SecretKeyAuth> {
         // There should be x and at least one y
-        if bytes.len() < 32 * 2 + 8 || (bytes.len() - 8) % 32 != 0 {
+        if bytes.len() < 32 * 2 + 8 || !(bytes.len() - 8).is_multiple_of(32) {
             return Err(CompactEcashError::DeserializationInvalidLength {
                 actual: bytes.len(),
                 modulus_target: bytes.len() - 8,
@@ -152,7 +152,7 @@ impl TryFrom<&[u8]> for VerificationKeyAuth {
 
     fn try_from(bytes: &[u8]) -> Result<VerificationKeyAuth> {
         // There should be at least alpha, one betaG1 and one betaG2 and their length
-        if bytes.len() < 96 * 2 + 48 + 8 || (bytes.len() - 8 - 96) % (96 + 48) != 0 {
+        if bytes.len() < 96 * 2 + 48 + 8 || !(bytes.len() - 8 - 96).is_multiple_of(96 + 48) {
             return Err(CompactEcashError::DeserializationInvalidLength {
                 actual: bytes.len(),
                 modulus_target: bytes.len() - 8 - 96,

common/nym_offline_compact_ecash/src/scheme/keygen.rs

@@ -44,7 +44,7 @@ impl From<u32> for SphinxKeyRotation {
     fn from(value: u32) -> Self {
         if value == 0 || value == u32::MAX {
             SphinxKeyRotation::Unknown
-        } else if value % 2 == 0 {
+        } else if value.is_multiple_of(2) {
             SphinxKeyRotation::EvenRotation
         } else {
             SphinxKeyRotation::OddRotation

common/nymsphinx/params/src/key_rotation.rs

@@ -168,7 +168,7 @@ impl BlindSignRequestBody {
     pub fn try_decode_joined_commitments(
         joined: &[u8],
     ) -> Result<Vec<G1Projective>, CompactEcashError> {
-        if joined.len() % 48 != 0 {
+        if !joined.len().is_multiple_of(48) {
             // that's not the most ideal error variant, but creating dedicated error type would have been an overkill
             return Err(CompactEcashError::DeserializationLengthMismatch {
                 type_name: "joined commitments".to_string(),

nym-api/nym-api-requests/src/ecash/models.rs

@@ -438,10 +438,6 @@ impl Default for HttpV10 {
     }
 }
 
-#[derive(Debug, Clone, Deserialize, PartialEq, Eq, Serialize)]
-#[serde(deny_unknown_fields)]
-pub struct MixnodePathsV10 {}
-
 #[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(deny_unknown_fields)]
 pub struct DebugV10 {
@@ -541,17 +537,6 @@ impl Default for VerlocDebugV10 {
     }
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize)]
-#[serde(deny_unknown_fields)]
-pub struct MixnodeConfigV10 {
-    pub storage_paths: MixnodePathsV10,
-
-    pub verloc: VerlocV10,
-
-    #[serde(default)]
-    pub debug: DebugV10,
-}
-
 impl DebugV10 {
     const DEFAULT_NODE_STATS_LOGGING_DELAY: Duration = Duration::from_millis(60_000);
     const DEFAULT_NODE_STATS_UPDATING_DELAY: Duration = Duration::from_millis(30_000);
@@ -566,21 +551,6 @@ impl Default for DebugV10 {
     }
 }
 
-#[derive(Debug, Clone, Deserialize, PartialEq, Eq, Serialize)]
-#[serde(deny_unknown_fields)]
-pub struct EntryGatewayPathsV10 {
-    /// Path to sqlite database containing all persistent data: messages for offline clients,
-    /// derived shared keys and available client bandwidths.
-    pub clients_storage: PathBuf,
-
-    pub stats_storage: PathBuf,
-
-    /// Path to file containing cosmos account mnemonic used for zk-nym redemption.
-    pub cosmos_mnemonic: PathBuf,
-
-    pub authenticator: AuthenticatorPathsV10,
-}
-
 #[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(default)]
 pub struct ZkNymTicketHandlerDebugV10 {
@@ -647,55 +617,6 @@ impl Default for ZkNymTicketHandlerDebugV10 {
     }
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize)]
-#[serde(deny_unknown_fields)]
-pub struct EntryGatewayConfigDebugV10 {
-    /// Number of messages from offline client that can be pulled at once (i.e. with a single SQL query) from the storage.
-    pub message_retrieval_limit: i64,
-    pub zk_nym_tickets: ZkNymTicketHandlerDebugV10,
-}
-
-impl EntryGatewayConfigDebugV10 {
-    const DEFAULT_MESSAGE_RETRIEVAL_LIMIT: i64 = 100;
-}
-
-impl Default for EntryGatewayConfigDebugV10 {
-    fn default() -> Self {
-        EntryGatewayConfigDebugV10 {
-            message_retrieval_limit: Self::DEFAULT_MESSAGE_RETRIEVAL_LIMIT,
-            zk_nym_tickets: Default::default(),
-        }
-    }
-}
-
-#[derive(Debug, Clone, Serialize, Deserialize)]
-#[serde(deny_unknown_fields)]
-pub struct EntryGatewayConfigV10 {
-    pub storage_paths: EntryGatewayPathsV10,
-
-    /// Indicates whether this gateway is accepting only coconut credentials for accessing the mixnet
-    /// or if it also accepts non-paying clients
-    pub enforce_zk_nyms: bool,
-
-    /// Socket address this node will use for binding its client websocket API.
-    /// default: `[::]:9000`
-    pub bind_address: SocketAddr,
-
-    /// Custom announced port for listening for websocket client traffic.
-    /// If unspecified, the value from the `bind_address` will be used instead
-    /// default: None
-    #[serde(deserialize_with = "de_maybe_port")]
-    pub announce_ws_port: Option<u16>,
-
-    /// If applicable, announced port for listening for secure websocket client traffic.
-    /// (default: None)
-    #[serde(deserialize_with = "de_maybe_port")]
-    pub announce_wss_port: Option<u16>,
-
-    #[serde(default)]
-    pub debug: EntryGatewayConfigDebugV10,
-}
-
 #[derive(Debug, Clone, Deserialize, PartialEq, Eq, Serialize)]
 #[serde(deny_unknown_fields)]
 pub struct NetworkRequesterPathsV10 {
@@ -786,20 +707,6 @@ pub struct AuthenticatorPathsV10 {
     // it's possible we might have to add credential storage here for return tickets
 }
 
-#[derive(Debug, Clone, Deserialize, PartialEq, Eq, Serialize)]
-#[serde(deny_unknown_fields)]
-pub struct ExitGatewayPathsV10 {
-    pub clients_storage: PathBuf,
-
-    pub stats_storage: PathBuf,
-
-    pub network_requester: NetworkRequesterPathsV10,
-
-    pub ip_packet_router: IpPacketRouterPathsV10,
-
-    pub authenticator: AuthenticatorPathsV10,
-}
-
 #[derive(Debug, Clone, Deserialize, PartialEq, Serialize)]
 pub struct AuthenticatorV10 {
     #[serde(default)]
@@ -928,45 +835,6 @@ impl Default for NetworkRequesterV10 {
     }
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize)]
-#[serde(deny_unknown_fields)]
-pub struct ExitGatewayDebugV10 {
-    /// Number of messages from offline client that can be pulled at once (i.e. with a single SQL query) from the storage.
-    pub message_retrieval_limit: i64,
-}
-
-impl ExitGatewayDebugV10 {
-    const DEFAULT_MESSAGE_RETRIEVAL_LIMIT: i64 = 100;
-}
-
-impl Default for ExitGatewayDebugV10 {
-    fn default() -> Self {
-        ExitGatewayDebugV10 {
-            message_retrieval_limit: Self::DEFAULT_MESSAGE_RETRIEVAL_LIMIT,
-        }
-    }
-}
-
-#[derive(Debug, Clone, Serialize, Deserialize)]
-#[serde(deny_unknown_fields)]
-pub struct ExitGatewayConfigV10 {
-    pub storage_paths: ExitGatewayPathsV10,
-
-    /// specifies whether this exit node should run in 'open-proxy' mode
-    /// and thus would attempt to resolve **ANY** request it receives.
-    pub open_proxy: bool,
-
-    /// Specifies the url for an upstream source of the exit policy used by this node.
-    pub upstream_exit_policy_url: Url,
-
-    pub network_requester: NetworkRequesterV10,
-
-    pub ip_packet_router: IpPacketRouterV10,
-
-    #[serde(default)]
-    pub debug: ExitGatewayDebugV10,
-}
-
 #[derive(Debug, Clone, Deserialize, PartialEq, Eq, Serialize)]
 #[serde(deny_unknown_fields)]
 pub struct GatewayTasksPathsV10 {