feat: migrate github.com/urfave/cli to v3 (#369)

* chore: migrate to linter v2 configs

* chore: update deps

* feat: migrate to github.com/urfave/cli v3

* fix: linter run scripts

* ci: update deprecated action

Author: obalunenko

.github/workflows/go.yml

@@ -254,7 +254,7 @@ jobs:
         shell: bash
 
       - name: SonarCloud report upload
-        uses: sonarsource/sonarcloud-github-action@v5.0
+        uses: SonarSource/sonarqube-scan-action@v5.2.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.golangci.pipe.yml

@@ -1,130 +1,95 @@
+version: "2"
+run:
+  issues-exit-code: 1
+  tests: true
+output:
+  formats:
+    text:
+    checkstyle:
+      path: report.xml
+  path-prefix: ""
 linters:
-  disable-all: true
+  default: none
   enable:
     - errcheck
-    - gofmt
     - revive
-    - goimports
-
-linters-settings:
-  errcheck:
-    check-type-assertions: true
-    check-blank: true
-  gofmt:
-    simplify: true
-  goimports:
-    local-prefixes: github.com/obalunenko/advent-of-code/
-  revive:
-    # see https://github.com/mgechev/revive#available-rules for details.
-    ignore-generated-header: true
-    severity: warning
-    rules:
-      - name: indent-error-flow
-        severity: warning
-      - name: exported
-        severity: warning
-      - name: defer
-        severity: warning
-        arguments: [ [ "call-chain", "loop", "method-call", "recover", "return" ] ]
-
-issues:
-  exclude-files:
-    - \.pb\.go$
-  exclude-dirs:
-    - vendor
-  exclude-use-default: false
-  exclude:
-    # for "public interface + private struct implementation" cases only!
-    - exported func * returns unexported type *, which can be annoying to use
-    - should have a package comment, unless it's in another file for this package
-  # Excluding configuration per-path, per-linter, per-text and per-source
-  exclude-rules:
-    # Exclude some linters from running on tests files.
-    - path: _test\.go
-      linters:
-        - gocyclo
-        - funlen
-        - dupl
-        - gosec
-    - path: internal/input/
-      linters:
-        - gocyclo
-        - funlen
-        - godot
-        - godox
-        - dupl
-        - gofmt
-        - gci
-        - gofumpt
-        - goimports
-        - gosimple
-    - path: internal/puzzles/constants.go
-      linters:
-        - revive
-
-      # Show only new issues: if there are unstaged changes or untracked files,
-      # only those changes are analyzed, else only changes in HEAD~ are analyzed.
-      # It's a super-useful option for integration of golangci-lint into existing
-      # large codebase. It's not practical to fix all existing issues at the moment
-      # of integration: much better don't allow issues in new code.
-      # Default is false.
-      new: true
-
-      # Fix found issues (if it's supported by the linter)
-      fix: false
-
-  severity:
-    # Default value is empty string.
-    # Set the default severity for issues. If severity rules are defined and the issues
-    # do not match or no severity is provided to the rule this will be the default
-    # severity applied. Severities should match the supported severity names of the
-    # selected out format.
-    # - Code climate: https://docs.codeclimate.com/docs/issues#issue-severity
-    # -   Checkstyle: https://checkstyle.sourceforge.io/property_types.html#severity
-    # -       GitHub: https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-error-message
-    default-severity: error
-
-    # The default value is false.
-    # If set to true severity-rules regular expressions become case sensitive.
-    case-sensitive: false
-
-    # Default value is empty list.
-    # When a list of severity rules are provided, severity information will be added to lint
-    # issues. Severity rules have the same filtering capability as exclude rules except you
-    # are allowed to specify one matcher per severity rule.
-    # Only affects out formats that support setting severity information.
+    - staticcheck
+    - unused
+  settings:
+    errcheck:
+      check-type-assertions: true
+      check-blank: true
+    revive:
+      severity: warning
+      rules:
+        - name: indent-error-flow
+          severity: warning
+        - name: exported
+          severity: warning
+        - name: defer
+          arguments:
+            - - call-chain
+              - loop
+              - method-call
+              - recover
+              - return
+          severity: warning
+  exclusions:
+    generated: lax
     rules:
       - linters:
           - dupl
-        severity: warning
-
-run:
-  issues-exit-code: 1
-  tests: true
-
-# output configuration options
-output:
-  # colored-line-number|line-number|json|tab|checkstyle|code-climate|junit-xml|github-actions
-  # default is "colored-line-number"
-  formats:
-    - format: colored-line-number
-      path: stderr
-    - format: checkstyle
-      path: linters-report.xml
-
-  # print lines of code with issue, default is true
-  print-issued-lines: true
-
-  # print linter name in the end of issue text, default is true
-  print-linter-name: true
-
-  # make issues output unique by line, default is true
+          - funlen
+          - gocyclo
+          - gosec
+        path: _test\.go
+      - linters:
+          - dupl
+          - funlen
+          - gocyclo
+          - godot
+          - godox
+          - staticcheck
+        path: internal/input/
+      - linters:
+          - revive
+        path: internal/puzzles/constants.go
+      - path: (.+)\.go$
+        text: exported func * returns unexported type *, which can be annoying to use
+      - path: (.+)\.go$
+        text: should have a package comment, unless it's in another file for this package
+    paths:
+      - \.pb\.go$
+      - vendor/
+      - third_party$
+      - builtin$
+      - examples$
+issues:
   uniq-by-line: true
-
-  # add a prefix to the output file references; default is no prefix
-  path-prefix: ""
-
-  # sorts results by: filepath, line and column
-  sort-results: true
-
-
+  new: true
+  fix: false
+severity:
+  default: error
+  rules:
+    - linters:
+        - dupl
+      severity: warning
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofmt:
+      simplify: true
+    goimports:
+      local-prefixes:
+        - github.com/obalunenko/advent-of-code
+  exclusions:
+    generated: lax
+    paths:
+      - \.pb\.go$
+      - vendor/
+      - third_party$
+      - builtin$
+      - examples$
+      - internal/input/