remove more title usage

Author: neo451

lua/obsidian/commands/extract_note.lua

@@ -16,21 +16,21 @@ return function(data)
   local content = vim.split(viz.selection, "\n", { plain = true })
 
   ---@type string|?
-  local title
+  local id
   if data.args ~= nil and string.len(data.args) > 0 then
-    title = vim.trim(data.args)
+    id = vim.trim(data.args)
   else
-    title = api.input "Enter title (optional): "
-    if not title then
+    id = api.input "Enter title (optional): "
+    if not id then
       log.warn "Aborted"
       return
-    elseif title == "" then
-      title = nil
+    elseif id == "" then
+      id = nil
     end
   end
 
   -- create the new note.
-  local note = Note.create { title = title }
+  local note = Note.create { id = id }
 
   -- replace selection with link to new note
   local link = note:format_link()

lua/obsidian/commands/link_new.lua

@@ -15,17 +15,17 @@ return function(data)
 
   local line = assert(viz.lines[1], "invalid visual selection")
 
-  local title
+  local id
   if string.len(data.args) > 0 then
-    title = data.args
+    id = data.args
   else
-    title = viz.selection
+    id = viz.selection
   end
 
-  local note = Note.create { title = title }
+  local note = Note.create { id = id }
 
   local new_line = string.sub(line, 1, viz.cscol - 1)
-    .. note:format_link { label = title }
+    .. note:format_link { label = id }
     .. string.sub(line, viz.cecol + 1)
 
   vim.api.nvim_buf_set_lines(0, viz.csrow - 1, viz.csrow, false, { new_line })

lua/obsidian/commands/new_from_template.lua

@@ -17,11 +17,11 @@ return function(data)
   end
 
   ---@type string?
-  local title = table.concat(data.fargs, " ", 1, #data.fargs - 1)
+  local id = table.concat(data.fargs, " ", 1, #data.fargs - 1)
   local template = data.fargs[#data.fargs]
 
-  if title ~= nil and template ~= nil then
-    local note = Note.create { title = title, template = template, should_write = true }
+  if id ~= nil and template ~= nil then
+    local note = Note.create { id = id, template = template, should_write = true }
     note:open { sync = true }
     return
   end
@@ -31,16 +31,16 @@ return function(data)
     dir = templates_dir,
     no_default_mappings = true,
     callback = function(template_name)
-      if title == nil or title == "" then
+      if id == nil or id == "" then
         -- Must use pcall in case of KeyboardInterrupt
         -- We cannot place `title` where `safe_title` is because it would be redeclaring it
         local success, safe_title = pcall(util.input, "Enter title or path (optional): ", { completion = "file" })
-        title = safe_title
+        id = safe_title
         if not success or not safe_title then
           log.warn "Aborted"
           return
         elseif safe_title == "" then
-          title = nil
+          id = nil
         end
       end
 
@@ -50,7 +50,7 @@ return function(data)
       end
 
       ---@type obsidian.Note
-      local note = Note.create { title = title, template = template_name, should_write = true }
+      local note = Note.create { id = id, template = template_name, should_write = true }
       note:open { sync = false }
     end,
   }

lua/obsidian/note.lua

@@ -1149,7 +1149,6 @@ end
 ---@field new_notes_location string
 
 ---@class obsidian.note.NoteOpts
----@field title string|? The note's title
 ---@field id string|? An ID to assign the note. If not specified one will be generated.
 ---@field dir string|obsidian.Path|? An optional directory to place the note in. Relative paths will be interpreted
 ---relative to the workspace / vault root. If the directory doesn't exist it will