[BUG]: Any media type that isn't JSON and that has UTF-8 charset get cast to text

[wolfy1339]

What happened?

It seems that ever since the very beginning of this project, it has been naively converting every file to text that has charset=utf-8 in it's content type.

The final condition in getResponseData() to return a simple ArrayBuffer is almost never reached because of that

request.js/src/fetch-wrapper.ts

Lines 168 to 172 in f7b9616

	} else if (
	mimetype.type.startsWith("text/") ||
	mimetype.parameters.charset?.toLowerCase() === "utf-8"
	) {
	return response.text().catch(() => "");

Reproduction:

import { Octokit } from "octokit";

const octokit = new Octokit({
    auth: "<token>"
});

const response = await octokit.rest.repos.getContent({
    owner: "wolfy1339",
    repo: "test-repository-test",
    path: "training.opus",
    mediaType: {
        format: "raw"
    }
});

console.log(request.data); // Mangled binary data

See also octokit/rest.js#14

Versions

Octokit 4.1.2

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

@gr2m Do you happen to remember why this is?

[gr2m]

No I'm sorry I don't remember ...