[IMP] {stock, mrp, repair}: allow picking_type change after confirm

Allow to change the picking type of picking, MO, RO even after they
are confirmed.

task-4104915

closes odoo#176456

Related: odoo/upgrade#6370
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Author: R1D1CUL0US

addons/mrp/views/mrp_production_views.xml

@@ -530,7 +530,7 @@
                         <page string="Miscellaneous" name="miscellaneous">
                             <group>
                                 <group>
-                                    <field name="picking_type_id" readonly="state != 'draft'"/>
+                                    <field name="picking_type_id" readonly="state not in ('draft', 'confirmed')"/>
                                     <field name="location_src_id" groups="stock.group_stock_multi_locations" options="{'no_create': True}" readonly="state != 'draft'"/>
                                     <field name="location_src_id" groups="!stock.group_stock_multi_locations" invisible="1"/>
                                     <field name="warehouse_id" invisible="1"/>

addons/repair/views/repair_views.xml

@@ -181,7 +181,7 @@
                     </page>
                     <page string="Miscellaneous" name="page_miscellaneous">
                         <group>
-                            <field name="picking_type_id" options="{'no_create': True}" readonly="state != 'draft'"/>
+                            <field name="picking_type_id" options="{'no_create': True}" readonly="state in ('done', 'cancel')"/>
                         </group>
                         <group string="Locations" groups="stock.group_stock_multi_locations" name="locations">
                             <field name="location_id" readonly="state != 'draft'" options="{'no_create': True}"/>

addons/stock/models/stock_move.py

@@ -708,6 +708,15 @@ def write(self, vals):
                     move_to_check_location.procure_method = 'make_to_stock'
                     move_to_check_location.move_orig_ids = [Command.clear()]
                     ml.unlink()
+        if 'location_id' in vals or 'location_dest_id' in vals:
+            wh_by_moves = defaultdict(self.env['stock.move'].browse)
+            for move in self:
+                move_warehouse = move.location_id.warehouse_id or move.location_dest_id.warehouse_id
+                if move_warehouse == move.warehouse_id:
+                    continue
+                wh_by_moves[move_warehouse] |= move
+            for warehouse, moves in wh_by_moves.items():
+                moves.warehouse_id = warehouse.id
         if move_to_confirm:
             move_to_confirm._action_assign()
         if receipt_moves_to_reassign:

addons/stock/models/stock_picking.py

@@ -628,7 +628,6 @@ def _default_picking_type_id(self):
     picking_type_entire_packs = fields.Boolean(related='picking_type_id.show_entire_packs')
     use_create_lots = fields.Boolean(related='picking_type_id.use_create_lots')
     use_existing_lots = fields.Boolean(related='picking_type_id.use_existing_lots')
-    hide_picking_type = fields.Boolean(compute='_compute_hide_picking_type')
     partner_id = fields.Many2one(
         'res.partner', 'Contact',
         check_company=True, index='btree_not_null')
@@ -711,11 +710,6 @@ def _compute_has_deadline_issue(self):
         for picking in self:
             picking.has_deadline_issue = picking.date_deadline and picking.date_deadline < picking.scheduled_date or False
 
-    @api.depends('state')
-    def _compute_hide_picking_type(self):
-        for picking in self:
-            picking.hide_picking_type = picking.state != "draft" and picking.ids and 'default_picking_type_id' in picking.env.context
-
     @api.depends('move_ids.delay_alert_date')
     def _compute_delay_alert_date(self):
         delay_alert_date_data = self.env['stock.move']._read_group([('id', 'in', self.move_ids.ids), ('delay_alert_date', '!=', False)], ['picking_id'], ['delay_alert_date:max'])
@@ -929,7 +923,7 @@ def _compute_show_allocation(self):
     @api.depends('picking_type_id', 'partner_id')
     def _compute_location_id(self):
         for picking in self:
-            if picking.state != 'draft' or picking.return_id:
+            if picking.state in ('cancel', 'done') or picking.return_id:
                 continue
             picking = picking.with_company(picking.company_id)
             if picking.picking_type_id:
@@ -1086,7 +1080,7 @@ def create(self, vals_list):
         return pickings
 
     def write(self, vals):
-        if vals.get('picking_type_id') and any(picking.state != 'draft' for picking in self):
+        if vals.get('picking_type_id') and any(picking.state in ('done', 'cancel') for picking in self):
             raise UserError(_("Changing the operation type of this record is forbidden at this point."))
         # set partner as a follower and unfollow old partner
         if vals.get('partner_id'):

addons/stock/tests/test_packing.py

@@ -1728,34 +1728,6 @@ def test_change_package_location(self):
         with self.assertRaises(UserError):
             pack_1.location_id = self.shelf1
 
-    def test_compute_hide_picking_type_multiple_records(self):
-        """
-        Create two pickings and compute their respective hide picking types together.
-        """
-        picking1 = self.env['stock.picking'].create({
-            'location_id': self.stock_location.id,
-            'location_dest_id': self.customer_location.id,
-            'picking_type_id': self.env.ref('stock.picking_type_out').id,
-        })
-        self.env['stock.move'].create({
-            'name': self.productA.name,
-            'product_id': self.productA.id,
-            'product_uom_qty': 10,
-            'product_uom': self.productA.uom_id.id,
-            'picking_id': picking1.id,
-            'location_id': self.stock_location.id,
-            'location_dest_id': self.customer_location.id,
-        })
-        picking1.action_confirm()
-        picking2 = self.env['stock.picking'].create({
-            'location_id': self.stock_location.id,
-            'location_dest_id': self.customer_location.id,
-            'picking_type_id': self.env.ref('stock.picking_type_out').id,
-        })
-        (picking1 | picking2).with_context(default_picking_type_id=self.ref('stock.picking_type_out'))._compute_hide_picking_type()
-        self.assertTrue(picking1.hide_picking_type)
-        self.assertFalse(picking2.hide_picking_type)
-
     def test_action_split_transfer(self):
         """ Check Split Picking if quantity `0 <= done < demand`
         """

addons/stock/tests/test_warehouse.py

@@ -3,8 +3,6 @@
 from odoo import Command
 from odoo.addons.stock.tests.common import TestStockCommon
 from odoo.tests import Form
-from odoo.exceptions import UserError
-from odoo.tools import mute_logger
 
 
 class TestWarehouse(TestStockCommon):
@@ -818,3 +816,37 @@ def test_location_warehouse(self):
         test_warehouse.sequence = 100
         location._compute_warehouse_id()
         self.assertEqual(location.warehouse_id, test_warehouse)
+
+    def test_location_updates_wh(self):
+        warehouse_A = self.env['stock.warehouse'].create({
+            'name': 'Warehouse X',
+            'code': 'WH_X',
+            'delivery_steps': 'pick_pack_ship'
+        })
+        warehouse_B = self.env['stock.warehouse'].create({
+            'name': 'Warehouse Y',
+            'code': 'WH_Y',
+            'delivery_steps': 'pick_pack_ship'
+        })
+        picking_out = self.env['stock.picking'].create({
+            'partner_id': self.partner.id,
+            'picking_type_id': warehouse_A.pick_type_id.id,
+            'location_id': warehouse_A.lot_stock_id.id,
+            'location_dest_id': self.env.ref('stock.stock_location_customers').id,
+        })
+        customer_move = self.env['stock.move'].create({
+            'name': self.product.name,
+            'product_id': self.product.id,
+            'product_uom_qty': 1,
+            'product_uom': self.product.uom_id.id,
+            'picking_id': picking_out.id,
+            'location_id': warehouse_A.lot_stock_id.id,
+            'location_dest_id': self.env.ref('stock.stock_location_customers').id,
+        })
+        picking_form = Form(picking_out)
+        picking_form.picking_type_id = warehouse_B.pick_type_id
+        picking_form.save()
+        self.assertEqual(customer_move.warehouse_id, warehouse_B)
+        self.assertEqual(picking_out.picking_type_id, warehouse_B.pick_type_id)
+        picking_out.button_validate()
+        self.assertEqual(customer_move.move_dest_ids.warehouse_id, warehouse_B)

addons/stock/views/stock_picking_views.xml

@@ -222,9 +222,8 @@
                             </div>
                             <field name="partner_id" nolabel="1" readonly="state in ['cancel', 'done']" placeholder="e.g. Lumber Inc"/>
                             <field name="picking_type_id" options="{'no_open': True}"
-                                   invisible="hide_picking_type"
-                                   readonly="state != 'draft' and id"
-                                   domain="context.get('restricted_picking_type_code') and [('code', '=', context.get('restricted_picking_type_code'))] or [(1,'=',1)]"/>
+                                   readonly="state in ('done', 'cancel')"
+                                   domain="[('code', 'in', ('incoming', 'outgoing', 'internal'))]" />
                             <field name="location_id" groups="!stock.group_stock_multi_locations" invisible="1" readonly="state == 'done'"/>
                             <field name="location_dest_id" groups="!stock.group_stock_multi_locations" invisible="1" readonly="state == 'done'"/>
                             <field name="location_id" options="{'no_create': True}" groups="stock.group_stock_multi_locations" invisible="picking_type_code == 'incoming'" readonly="state == 'done'"/>