Merge pull request #3 from omaralalwi/add-more-tests

add more tests

Author: omaralalwi

example-scripts/advance_example.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+# this shell script just for tests
+
+# Check if at least one argument is provided
+if [ $# -eq 0 ]; then
+    echo '{"error": "At least one numeric argument is required."}'
+    exit 1
+fi
+
+# Initialize sum
+sum=0
+
+# Iterate over arguments and check if they are numbers
+for arg in "$@"; do
+    if ! [[ "$arg" =~ ^-?[0-9]+([.][0-9]+)?$ ]]; then
+        echo '{"error": "All arguments must be numeric."}'
+        exit 1
+    fi
+    sum=$(echo "$sum + $arg" | bc)
+done
+
+# Output the sum in JSON format
+echo "$sum"

src/PhpPy.php

@@ -74,15 +74,15 @@ public function loadScript(string $path): self
         }
 
         if (!str_starts_with($realPath, $allowedDirReal . DIRECTORY_SEPARATOR)) {
-            throw new InvalidArgumentException("Script path is not within the allowed directory.");
+            throw new InvalidArgumentException("Script path {$realPath} is not within the allowed directory.");
         }
 
         if (!is_file($realPath)) {
-            throw new InvalidArgumentException("Script path is not a file.");
+            throw new InvalidArgumentException("Script path {$realPath} is not a file.");
         }
 
         if (!is_readable($realPath)) {
-            throw new InvalidArgumentException("Script file is not readable.");
+            throw new InvalidArgumentException("Script file {$realPath} is not readable.");
         }
 
         if (pathinfo($realPath, PATHINFO_EXTENSION) !== 'py') {

tests/PhpPyTest.php

@@ -20,6 +20,27 @@
     expect(json_decode($result))->toBe(60.0);
 });
 
+test('PhpPy does not pass shell scripts', function () {
+
+    $configManager = new ConfigManager([
+        'scripts_directory' => __DIR__ . '/../example-scripts',
+        'python_executable' => '/usr/bin/python3',
+        'max_timeout' => 30,
+    ]);
+
+    $this->expectException(\InvalidArgumentException::class);
+    $this->expectExceptionMessage('Script path does not exist.');
+
+    $result = PhpPy::build()
+        ->setConfig($configManager)
+        ->loadScript('sum_calculator.sh')
+        ->withArguments([10, 20, 30])
+        ->run();
+
+    expect(json_decode($result))->toBe(60.0);
+});
+
+
 test('PhpPy throws exception when try to run script outside allowed path', function () {
 
     $configManager = new ConfigManager([