From 685ecb90c9aa16a5e52d8e85931cab3de9cec121 Mon Sep 17 00:00:00 2001 From: Chen Tong Date: Sun, 16 Feb 2025 22:01:43 -0500 Subject: [PATCH 1/2] change Signed-off-by: Chen Tong --- src/Compiler/CompilerOptions.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Compiler/CompilerOptions.cpp b/src/Compiler/CompilerOptions.cpp index 4810a47a41..db93e3c6c9 100644 --- a/src/Compiler/CompilerOptions.cpp +++ b/src/Compiler/CompilerOptions.cpp @@ -577,8 +577,8 @@ static llvm::cl::opt verifyInputTensorsOpt("verifyInputTensors", llvm::cl::desc( "Verify input tensors whenever the entry point function is called.\n" "Data type and shape are verified. Enable this may introduce overhead " - "at runtime."), - llvm::cl::location(verifyInputTensors), llvm::cl::init(false), + "at runtime. Default is true"), + llvm::cl::location(verifyInputTensors), llvm::cl::init(true), llvm::cl::cat(OnnxMlirOptions)); static llvm::cl::opt allowSortingOpt("allowSorting", From d91dc99b656efd235f1228dcb0c497043dcb89fa Mon Sep 17 00:00:00 2001 From: Chen Tong Date: Tue, 18 Feb 2025 10:35:37 -0500 Subject: [PATCH 2/2] handle null Signed-off-by: Chen Tong --- src/Conversion/KrnlToLLVM/KrnlEntryPoint.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Conversion/KrnlToLLVM/KrnlEntryPoint.cpp b/src/Conversion/KrnlToLLVM/KrnlEntryPoint.cpp index 3eec020df7..261e2b3050 100644 --- a/src/Conversion/KrnlToLLVM/KrnlEntryPoint.cpp +++ b/src/Conversion/KrnlToLLVM/KrnlEntryPoint.cpp @@ -450,6 +450,7 @@ class KrnlEntryPointOpLowering : public OpRewritePattern { auto JSONItemType = JSONItem->getString("type"); assert(JSONItemType && "failed to get type"); Type elemTy = parseType(JSONItemType.value(), rewriter.getContext()); + if (elemTy) { std::string elemTyStr; llvm::raw_string_ostream dstream(elemTyStr); dstream << elemTy; @@ -461,6 +462,7 @@ class KrnlEntryPointOpLowering : public OpRewritePattern { "Wrong data type for the input " + std::to_string(i) + ": expect " + elemTyStr, false); + } // Verify data rank. auto JSONDimArray = JSONItem->getArray("dims");