Skip to content

Commit 53810d5

Browse files
authored
Merge pull request #70 from oslabs-beta/remove-electron-devtools-vendor
Remove electron-devtools-vendor
2 parents 810fdf7 + 44fef68 commit 53810d5

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

package-lock.json

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@
118118
"css-loader": "^6.7.3",
119119
"depcheck": "^1.4.3",
120120
"dotenv": "^16.0.3",
121-
"electron-devtools-vendor": "^1.2.0",
122121
"electron-reload": "^2.0.0-alpha.1",
123122
"electron-reloader": "^1.2.3",
124123
"electron-squirrel-startup": "^1.0.0",

public/electron.jsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const path = require('path');
66
const fs = require('fs');
77
const np = require('node-pty');
88
const os = require('os');
9-
const { REACT_DEVELOPER_TOOLS } = require('electron-devtools-vendor');
109

1110
// app.commandLine.appendSwitch('--headless');
1211
// app.commandLine.appendSwitch('--no-sandbox');
@@ -275,18 +274,11 @@ ipcMain.on('Google-Oauth', (_event, url) => {
275274
});
276275
});
277276

278-
// electron-devtools-vendor needs to be installed at v1.1 due to a bug with 1.2
279-
// where it is not accounting for a change in the newest version of the react dev tool itself
280277
app.whenReady()
281278
.then(createWindow)
282279
.then(app.on('activate', () => {
283280
if (BrowserWindow.getAllWindows().length === 0) createWindow()
284281
}))
285-
.then(() => {
286-
session.defaultSession.loadExtension(REACT_DEVELOPER_TOOLS, { allowFileAccess: true })
287-
.then((name) => console.log(`Added Extension: ${name}`))
288-
.catch((err) => console.log(`An error occurred adding an extension: ${err}`));
289-
})
290282
.catch((err) => console.log(`An error occurred when booting up electron: ${err}`));
291283

292284

0 commit comments

Comments
 (0)