Skip to content

feat: Allowed user-defined formatterInterface in opentelemetry-logger-monolog #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Allowed user-defined formatterInterface in opentelemetry-logger-monolog #458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63283d0
Allowed user-defined formatterInterface
jerrytfleung Nov 13, 2025
25be918
Fixed Phan errors
jerrytfleung Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Logs/Monolog/src/Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ class Handler extends AbstractProcessingHandler
/** @var API\LoggerInterface[] */
private array $loggers = [];
private API\LoggerProviderInterface $loggerProvider;
private ?FormatterInterface $formatterInterface;

/**
* @psalm-suppress InvalidArgument
*/
public function __construct(API\LoggerProviderInterface $loggerProvider, $level, bool $bubble = true)
public function __construct(API\LoggerProviderInterface $loggerProvider, $level, bool $bubble = true, ?FormatterInterface $formatterInterface = null)
{
parent::__construct($level, $bubble);
$this->loggerProvider = $loggerProvider;
$this->formatterInterface = $formatterInterface;
}

protected function getLogger(string $channel): API\LoggerInterface
Expand All @@ -36,7 +38,7 @@ protected function getLogger(string $channel): API\LoggerInterface

protected function getDefaultFormatter(): FormatterInterface
{
return new NormalizerFormatter();
return $this->formatterInterface ?? new NormalizerFormatter();
}

/**
Expand Down