Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Commit 33aedec

Browse files
committed
Merge branch 'main' into jack/bug/nwp-example-is-wrong-shape
2 parents 2c4ce32 + 000710e commit 33aedec

File tree

6 files changed

+9
-4
lines changed

6 files changed

+9
-4
lines changed

.bumpversion.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[bumpversion]
22
commit = True
33
tag = True
4-
current_version = 2.0.39
4+
current_version = 2.0.43
55

66
[bumpversion:file:setup.py]
77
search = version="{current_version}"

nowcasting_dataset/config/model.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,9 @@ class PV(DataSourceMixin):
101101
get_center: bool = Field(
102102
False,
103103
description="If the batches are centered on one PV system (or not). "
104-
"The other options is to have one GSP at the center of a batch. ",
104+
"The other options is to have one GSP at the center of a batch. "
105+
"Typically, get_center would be set to true if and only if "
106+
"PVDataSource is used to define the geospatial positions of each example.",
105107
)
106108

107109

nowcasting_dataset/data_sources/nwp/nwp_data_source.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def _post_process_example(self, selected_data: xr.Dataset, t0_dt: pd.Timestamp)
135135

136136
selected_data = selected_data.sel(target_time=slice(start_dt, end_dt))
137137
selected_data = selected_data.rename({"target_time": "time", "variable": "channels"})
138-
selected_data.data = selected_data.data.astype(np.float16)
138+
selected_data.data = selected_data.data.astype(np.float32)
139139

140140
return selected_data
141141

nowcasting_dataset/manager.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ def save_yaml_configuration(self):
5656
"""Save configuration to the 'output_data' location"""
5757
config.save_yaml_configuration(configuration=self.config)
5858

59+
# TODO: Issue #322: Write test for Manager.configure_loggers()
5960
def configure_loggers(
6061
self,
6162
log_level: str,

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
setup(
1212
name="nowcasting_dataset",
13-
version="2.0.39",
13+
version="2.0.43",
1414
license="MIT",
1515
description="Nowcasting Dataset",
1616
author="Jack Kelly, Peter Dudfield, Jacob Bieker",

tests/test_manager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
from nowcasting_dataset.data_sources.sun.sun_data_source import SunDataSource
1414
from nowcasting_dataset.manager import Manager
1515

16+
# TODO: Issue #322: Write test for Manager.configure_loggers()
17+
1618

1719
def test_sample_spatial_and_temporal_locations_for_examples(): # noqa: D103
1820
local_path = Path(nowcasting_dataset.__file__).parent.parent

0 commit comments

Comments
 (0)