Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Commit 463ea18

Browse files
committed
only warning if nans in nwp
1 parent 7e103a5 commit 463ea18

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

nowcasting_dataset/data_sources/datasource_output.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,18 @@ def check_nan_and_inf(self, data: xr.Dataset, variable_name: str = None):
6969
logger.error(message)
7070
raise Exception(message)
7171

72+
def check_nan_and_fill_warning(self, data: xr.Dataset, variable_name: str = None) -> xr.Dataset:
73+
"""Check that all values are non NaNs and not infinite"""
74+
75+
if np.isnan(data).any():
76+
message = f"Some {self.__class__.__name__} data values are NaNs"
77+
if variable_name is not None:
78+
message += f" ({variable_name})"
79+
logger.warning(message)
80+
data = data.fillna(0)
81+
82+
return data
83+
7284
def check_dataset_greater_than_or_equal_to(
7385
self, data: xr.Dataset, min_value: int, variable_name: str = None
7486
):

nowcasting_dataset/data_sources/nwp/nwp_model.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ class NWP(DataSourceOutput):
2121
def model_validation(cls, v):
2222
"""Check that all values are not NaNs"""
2323

24-
v.check_nan_and_inf(data=v.data)
24+
# TODO issue 481, change back to 'check_nan_and_inf'
25+
v.__setitem__("data", v.check_nan_and_fill_warning(data=v.data))
2526

2627
v.check_data_var_dim(
2728
v.data, ("example", "time_index", "x_index", "y_index", "channels_index")

0 commit comments

Comments
 (0)