Skip to content

Commit 59bb7f1

Browse files
committed
grammar and additional clarifications
1 parent b514ad9 commit 59bb7f1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Documentation/framework.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ description of the scopes is provided in the [review areas](./review_areas.md) d
218218
the firmware, and the corresponding Confidentiality, Integrity and Availability requirements for each. Examples of
219219
critical assets may include secret keys, the fuse configuration, or any configuration data residing in external flash.
220220

221-
The SAFE program defines 3 security review scopes. These scopes increase the complexity of attacks in the threat model.
221+
The SAFE program defines 3 security review scopes. These scopes increase with complexity of attacks in the threat model.
222222
It is expected that devices will have reviews done with different review scopes. For example, a CPU may have a scope 3
223223
review of the root of trust due to the need for glitch protection when using a long-term device private key. This CPU
224224
may use a scope 2 review for the application cores.
@@ -257,7 +257,7 @@ may use a scope 2 review for the application cores.
257257
* Safe generation and handling of all cryptographic material.
258258
* Encryption capability controls (disk encryption, erase, rotation).
259259
* Secure boot key rotation capabilities.
260-
* **Scope 2 - Focusing on Trust boundaries**
260+
* **Scope 2 - Focusing on Trust boundaries:** Includes all of the areas of Scope 1 above, with deeper review focus of the following areas:
261261
* Trusted execution environment assessment
262262
* Handling of trust boundaries
263263
* Attestation and non-repudiation across boundaries
@@ -295,10 +295,10 @@ has concluded:
295295
* **Signed Git Commits**\
296296
The OCP GitHub repository is configured to require all commits to be [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits). Please remember this when preparing the submission (use [--amend --signoff](https://stackoverflow.com/a/15667644) if you forget).
297297
* **SRF Pull Request Path**\
298-
The location of the signed SFRs should be in Reports/$Vendor/$Year/$Product. As a convenience,
298+
The signed SFRs are published to the location Reports/$Vendor/$Year/$Product. As a convenience,
299299
the submission may choose to additionally include the human-readable SFR documents.
300300
* **SRP Public Key Pull Request Path**\
301-
The location of the signing public key should be in SRP_certificates/$SRP. These are to be published and maintained by
301+
The public signing key of each SRP is published to the location SRP_certificates/$SRP. These are to be published and maintained by
302302
the SRP, and may be revoked by the TAC (see [Disqualification](#Disqualification) above).
303303

304304

0 commit comments

Comments
 (0)