Skip to content

odsComponentStageCopyImage outputs/logs skopeo registry credentials (src, dst) #1178

@tbugfinder

Description

@tbugfinder

The odsComponentStageCopyImage logs the source and destination credentials as the shell output is not masked or postprocessed.

A simple approach could be using set +x or adding some wtihCredentials code.
Using set +x might be quickest solution however a user might still need details of the command.

script: """
skopeo copy ${copyparams} \
--src-tls-verify=${this.options.verifyTLS} ${sourcetoken} \
${this.options.registry}/${this.options.repo}/${this.options.image} \
--dest-creds openshift:${targetInternalRegistryToken} \
${dockerProtocol}${context.clusterRegistryAddress}/${context.cdProject}/${this.options.image} \
--dest-tls-verify=${this.options.verifyTLS}

Ref: #212 #341

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions