From 964f5d7b9b186b461405168e341b60d2d766bcbb Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Mon, 5 Jan 2026 09:57:52 -0500 Subject: [PATCH] fix: Don't try to save artifacts if we didn't release. Update the name of the second step to be more clear and correct the related comment as well. --- .github/workflows/release.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6346d9f..bb8f4b4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -56,6 +56,7 @@ jobs: - name: Upload | Distribution Artifacts uses: actions/upload-artifact@v4 + if: steps.release.outputs.released == 'true' with: name: distribution-artifacts path: backend/dist @@ -64,10 +65,10 @@ jobs: outputs: released: ${{ steps.release.outputs.released || 'false' }} - deploy: - # 1. Separate out the deploy step from the publish step to run each step at + publish: + # 1. Separate out the publish step from the github release step to run each step at # the least amount of token privilege - # 2. Also, deployments can fail, and its better to have a separate job if you need to retry + # 2. Also, publishing can fail, and its better to have a separate job if you need to retry # and it won't require reversing the release. runs-on: ubuntu-latest needs: release