Skip to content

Commit 5d104a6

Browse files
committed
remove redundant test
1 parent bfa339b commit 5d104a6

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

tests/index.test.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -272,26 +272,6 @@ describe("OpenFGA SDK", function () {
272272
})
273273
).toThrow();
274274
});
275-
276-
it("should only accept valid telemetry metrics", async () => {
277-
278-
expect(
279-
() =>
280-
new OpenFgaApi({
281-
...baseConfig,
282-
telemetry: {
283-
metrics: {
284-
histogramRequestDuration: {
285-
attributes: new Set<TelemetryAttribute>
286-
},
287-
counterCredentialsRequest: {
288-
attributes: ["JUNK"] as any
289-
},
290-
}
291-
}
292-
})
293-
).toThrow();
294-
});
295275
});
296276

297277
describe("error handling", () => {

tests/telemetry/configuration.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,4 @@ describe("TelemetryConfiguration", () => {
8484
])));
8585
expect(config.metrics.histogramRequestDuration?.attributes).toEqual(TelemetryConfiguration.defaultAttributes);
8686
});
87-
88-
// TODO verify behavior for only specifying some of the metrics, what should the others be set to?
8987
});

0 commit comments

Comments
 (0)