8365699: Remove jdk.internal.javac.PreviewFeature.Feature enum values for features finalized in Java 25 or earlier

[jaikiran]

Can I please get a review of this change which cleans up the outdated enum constants in the internal jdk.internal.javac.PreviewFeature$Feature enum?

This addresses https://bugs.openjdk.org/browse/JDK-8365699. As noted in that issue, this enum has accumulated some outdated preview feature constants which are no longer needed. The changes in this PR removes those enum constants whose preview features have been finalized in Java 25 or earlier (the current mainline bootstrap JDK is Java 25). A code comment explaining the lifetime of these enum constants has also been added.

No new tests have been introduced and tier1, tier2, tier3 testing is currently in progress in the CI.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365699: Remove jdk.internal.javac.PreviewFeature.Feature enum values for features finalized in Java 25 or earlier (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)
• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28128/head:pull/28128
$ git checkout pull/28128

Update a local copy of the PR:
$ git checkout pull/28128
$ git pull https://git.openjdk.org/jdk.git pull/28128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28128

View PR using the GUI difftool:
$ git pr show -t 28128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28128.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365699: Remove jdk.internal.javac.PreviewFeature.Feature enum values for features finalized in Java 25 or earlier

Reviewed-by: vromero, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• d5831ed: 8357880: Code formatting typo in Cipher.getMaxAllowedParameterSpec
• 1357be9: 8371178: Preserve fast version of getfield and putfield in AOTCache
• acc8a76: 8357034: GifImageDecoder can produce wrong transparent pixels
• ... and 41 more: https://git.openjdk.org/jdk/compare/e4aed95cac343f1339b9bc87721561bdc4c2f5ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a46ea215)

[jaikiran]

tier1, tier2 and tier3 testing of this change completed without any failures.

[vicente-romero-oracle]

lgtm

[jaikiran]

Thank you Vicente and Chen for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 188da51.
Since your change was applied there have been 44 commits pushed to the master branch:

• d5831ed: 8357880: Code formatting typo in Cipher.getMaxAllowedParameterSpec
• 1357be9: 8371178: Preserve fast version of getfield and putfield in AOTCache
• acc8a76: 8357034: GifImageDecoder can produce wrong transparent pixels
• ... and 41 more: https://git.openjdk.org/jdk/compare/e4aed95cac343f1339b9bc87721561bdc4c2f5ad...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 188da51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.