Skip to content

Conversation

@hns
Copy link
Member

@hns hns commented Nov 4, 2025

Please review a change to fix broken links in sealed type hierarchy graphs for nested types. The problem is that enclosing types are included in the path of the graph file and therefore must have a matching ../ in the generated link.

Fixed graphs for some nested sealed types:

There is currently no test coverage for the sealed graph taglet. I tested the fix manually, a test should be added with JDK-8366828.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366094: Sealed graph for nested types creates broken links (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28134/head:pull/28134
$ git checkout pull/28134

Update a local copy of the PR:
$ git checkout pull/28134
$ git pull https://git.openjdk.org/jdk.git pull/28134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28134

View PR using the GUI difftool:
$ git pr show -t 28134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28134.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org build build-dev@openjdk.org labels Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@hns The following labels will be automatically applied to this pull request:

  • build
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org javadoc javadoc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant