8366094: Sealed graph for nested types creates broken links #28134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review a change to fix broken links in sealed type hierarchy graphs for nested types. The problem is that enclosing types are included in the path of the graph file and therefore must have a matching
../in the generated link.Fixed graphs for some nested sealed types:
There is currently no test coverage for the sealed graph taglet. I tested the fix manually, a test should be added with JDK-8366828.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28134/head:pull/28134$ git checkout pull/28134Update a local copy of the PR:
$ git checkout pull/28134$ git pull https://git.openjdk.org/jdk.git pull/28134/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28134View PR using the GUI difftool:
$ git pr show -t 28134Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28134.diff
Using Webrev
Link to Webrev Comment