-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8354937: Cleanup some sparc related coding in os_linux #28143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
RealLucy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
Thanks for the reviews ! /integrate |
|
Going to push as commit 1b3889a.
Your commit was automatically rebased without conflicts. |
There is still some SPARC related coding remaining in os_linux, but we do not support Linux on SPARC for quite some time.
(there is more SPARC coding for detecting Sparc shared libs but I kept, that for now; not sure how important this is these days see https://github.com/openjdk/jdk/blob/master/src/hotspot/os/linux/os_linux.cpp#L1762 )
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28143/head:pull/28143$ git checkout pull/28143Update a local copy of the PR:
$ git checkout pull/28143$ git pull https://git.openjdk.org/jdk.git pull/28143/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28143View PR using the GUI difftool:
$ git pr show -t 28143Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28143.diff
Using Webrev
Link to Webrev Comment