Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 5, 2025

There is still some SPARC related coding remaining in os_linux, but we do not support Linux on SPARC for quite some time.

(there is more SPARC coding for detecting Sparc shared libs but I kept, that for now; not sure how important this is these days see https://github.com/openjdk/jdk/blob/master/src/hotspot/os/linux/os_linux.cpp#L1762 )


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354937: Cleanup some sparc related coding in os_linux (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28143/head:pull/28143
$ git checkout pull/28143

Update a local copy of the PR:
$ git checkout pull/28143
$ git pull https://git.openjdk.org/jdk.git pull/28143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28143

View PR using the GUI difftool:
$ git pr show -t 28143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28143.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354937: Cleanup some sparc related coding in os_linux

Reviewed-by: ayang, mdoerr, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8354937: Cleanup some sparc related coding in os_linux 8354937: Cleanup some sparc related coding in os_linux Nov 5, 2025
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 5, 2025
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MBaesken
Copy link
Member Author

MBaesken commented Nov 6, 2025

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

Going to push as commit 1b3889a.
Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2025
@openjdk openjdk bot closed this Nov 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2025
@openjdk
Copy link

openjdk bot commented Nov 6, 2025

@MBaesken Pushed as commit 1b3889a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants