Skip to content

Commit f7cea50

Browse files
Applying suggestion
1 parent b6a81a1 commit f7cea50

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/main/java/org/openrewrite/java/dependencies/search/ModuleHasDependency.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,8 @@ public Tree visit(@Nullable Tree tree, ExecutionContext ctx) {
120120
String dependencyGav = groupIdPattern + ":" + artifactIdPattern + (version == null ? "" : ":" + version);
121121
if (shouldInvert && !acc.contains(jp)) {
122122
return SearchResult.found(tree, "Module does not have dependency: " + dependencyGav);
123-
} else if (!shouldInvert && acc.contains(jp)) {
123+
}
124+
if (!shouldInvert && acc.contains(jp)) {
124125
return SearchResult.found(tree, "Module has dependency: " + dependencyGav);
125126
}
126127
return tree;

src/test/java/org/openrewrite/java/dependencies/search/ModuleHasDependencyTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ public void defaults(RecipeSpec spec) {
4646
spec.beforeRecipe(withToolingApi());
4747
}
4848

49-
@ParameterizedTest
5049
@NullSource
50+
@ParameterizedTest
5151
@ValueSource(booleans = {false})
5252
void whenModuleHasDirectDependencyMarks(Boolean invertCondition) {
5353
final String groupId = "org.springframework";
@@ -178,8 +178,8 @@ public class AMaven {}
178178
);
179179
}
180180

181-
@ParameterizedTest
182181
@NullSource
182+
@ParameterizedTest
183183
@ValueSource(booleans = {false})
184184
void whenModuleHasTransitiveDependencyMarks(Boolean invertCondition) {
185185
final String groupId = "org.springframework";
@@ -310,8 +310,8 @@ public class AMaven {}
310310
);
311311
}
312312

313-
@ParameterizedTest
314313
@NullSource
314+
@ParameterizedTest
315315
@ValueSource(booleans = {false})
316316
void whenModuleDoesNotHaveDependencyDoesNotMark(Boolean invertCondition) {
317317
rewriteRun(

0 commit comments

Comments
 (0)