Inconvertible Mockito when situation involving lambda and static method. (#763)

* Showing situation where we wouldn't be able to safely convert `when(...).thenReturn(..)` to `staticMocked.when(...).thenReturn(..)`

* Adding a change that would prevent it from tring to use a lambda parameter as a class, which leads to something that can't be compiled.

* Update src/main/java/org/openrewrite/java/testing/mockito/MockitoWhenOnStaticToMockStatic.java

---------

Co-authored-by: Sam Snyder <sam@moderne.io>

Author: steve-aom-elliott

src/main/java/org/openrewrite/java/testing/mockito/MockitoWhenOnStaticToMockStatic.java

@@ -120,7 +120,8 @@ private List<Statement> maybeWrapStatementsInTryWithResourcesMockedStatic(J.Bloc
 
             private @Nullable String getClassName(J.MethodInvocation whenArg) {
                 J.Identifier clazz = null;
-                if (whenArg.getSelect() instanceof J.Identifier) {
+                // Having a fieldType implies that something is a field rather than a class itself
+                if (whenArg.getSelect() instanceof J.Identifier && ((J.Identifier) whenArg.getSelect()).getFieldType() == null) {
                     clazz = (J.Identifier) whenArg.getSelect();
                 } else if (whenArg.getSelect() instanceof J.FieldAccess && ((J.FieldAccess) whenArg.getSelect()).getTarget() instanceof J.Identifier) {
                     clazz = (J.Identifier) ((J.FieldAccess) whenArg.getSelect()).getTarget();

src/test/java/org/openrewrite/java/testing/mockito/MockitoWhenOnStaticToMockStaticTest.java

@@ -31,7 +31,7 @@ class MockitoWhenOnStaticToMockStaticTest implements RewriteTest {
         public class A {
             public static Integer getNumber() {
                 return 42;
-           }
+            }
         }
         """,
       SourceSpec::skip
@@ -43,7 +43,10 @@ public static Integer getNumber() {
         public class B {
             public static String getString() {
                 return "";
-           }
+            }
+            public String getStringNonStatic() {
+                return "non-static";
+            }
         }
         """,
       SourceSpec::skip
@@ -150,6 +153,45 @@ void test() {
         );
     }
 
+    @Test
+    void doNotConvertIfScopeOfChangeWouldHaveToBeBroadened() {
+        rewriteRun(
+          spec -> spec.afterTypeValidationOptions(TypeValidation.builder().identifiers(false).build()),
+          CLASS_B,
+          //language=java
+          java(
+            """
+              import org.mockito.MockedConstruction;
+              import org.mockito.MockedStatic;
+
+              import static org.mockito.Mockito.*;
+
+              class Test {
+                  void method() {
+                      // Would have to be changed starting here
+                      try (MockedConstruction<B> bMockConstruction = mockConstruction(B.class,
+                          (mock, context) -> {
+                              // Rather than just here
+                              when(mock.getString()).thenReturn("first");
+                          }
+                      )) {
+                          // Nothing here
+                      }
+                      // Doesn't require a change
+                      try (MockedConstruction<B> bMockConstruction = mockConstruction(B.class,
+                          (mock, context) -> {
+                              when(mock.getStringNonStatic()).thenReturn("second");
+                          }
+                      )) {
+                          // Nothing here
+                      }
+                  }
+              }
+              """
+          )
+        );
+    }
+
     @Test
     void shouldHandleMultipleStaticMocksAndNestedStatements() {
         //language=java