From f87aa3b9d0594213ef276a3fea1ed7fdca4283bb Mon Sep 17 00:00:00 2001
From: Shawn Kovalchick <shawn.kovalchick@digitalturbine.com>
Date: Mon, 5 Oct 2020 15:10:20 -0400
Subject: [PATCH] Added a few tests for the examples in the readme and
 corrected the readme accordingly

---
 README.md      | 16 ++++------------
 tests/tests.js | 48 ++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 50 insertions(+), 14 deletions(-)

diff --git a/README.md b/README.md
index f2f76e2..614b804 100644
--- a/README.md
+++ b/README.md
@@ -28,17 +28,9 @@ Output will be:
 
 ```
 [
-  {
-    code: "en",
-    region: "GB",
-    quality: 1.0
-  },
-  {
-    code: "en",
-    region: undefined,
-    quality: 0.8
-  }
-];
+  { code: 'en', script: null, region: 'GB', quality: 1 },
+  { code: 'en', script: null, region: undefined, quality: 0.8 }
+]
 ```
 
 Output is always sorted in quality order from highest -> lowest. As per the HTTP spec, omitting the quality value implies 1.0.
@@ -72,7 +64,7 @@ parser.pick(['fr', 'en'], 'en-GB,en-US;q=0.9,fr-CA;q=0.7,en;q=0.8', { loose: tru
 Would return:
 
 ```javascript
-"fr"
+"en"
 ```
 
 In loose mode the order of `supportedLanguagesArray` matters, as it is the first partially matching language that is returned. It means that if you want to pick more specific langauges first, you should list it first as well. 
diff --git a/tests/tests.js b/tests/tests.js
index 34c0f09..eff780c 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -155,8 +155,52 @@ describe('accept-language#pick()', function(){
         assert.equal(result, 'en');
     });
 
-    it('selects most matching language in loose mode', function(){
-        var result = parser.pick(['en-US', 'en', 'pl'], 'en-US;q=0.6', { loose: true });
+    it('selects the first matching language in loose mode, even when supported language is more restrictive', function(){
+        var result = parser.pick(['en-US', 'en', 'pl'], 'en;q=0.6', { loose: true });
         assert.equal(result, 'en-US');
     });
+
+    it('selects the first matching language in loose mode, even when the accepted language is more restrictive', function(){
+        var result = parser.pick(['en', 'en-US', 'pl'], 'en-US;q=0.6', { loose: true });
+        assert.equal(result, 'en');
+    });
+
+    it('quality is more important than order when matching loosely', function(){
+        var result = parser.pick(['en', 'fr'], 'fr-CA,fr;q=0.8,en-US;q=0.6,en;q=0.4,*;q=0.1', { loose: true });
+        var result2 = parser.pick(['fr', 'en'], 'fr-CA,fr;q=0.8,en-US;q=0.6,en;q=0.4,*;q=0.1', { loose: true });
+        assert.equal(result, result2);
+    });
+
+    it('quality is more important than order when matching loosely2', function(){
+        var result = parser.pick(['en', 'fr'], 'fr-CA,en-US;q=0.7,fr;q=0.6,en;q=0.4,*;q=0.1', { loose: true });
+        var result2 = parser.pick(['fr', 'en'], 'fr-CA,en-US;q=0.7,fr;q=0.6,en;q=0.4,*;q=0.1', { loose: true });
+        assert.equal(result, result2);
+    });
+
+    it('quality is more important than order when matching loosely3', function(){
+        var result = parser.pick(['en', 'fr'], 'en-US;q=0.7,fr;q=0.6,en;q=0.4,*;q=0.1', { loose: true });
+        var result2 = parser.pick(['fr', 'en'], 'en-US;q=0.7,fr;q=0.6,en;q=0.4,*;q=0.1', { loose: true });
+        assert.equal(result, result2);
+    });
+
+});
+
+describe('readme examples', function(){
+    it('parser.parse()', function(){
+        var result = parser.parse('en-GB,en;q=0.8');
+        assert.deepStrictEqual(result, [
+            { code: 'en', script: null, region: 'GB', quality: 1 },
+            { code: 'en', script: null, region: undefined, quality: 0.8 }
+        ]);
+    });
+
+    it('parser.pick() strict', function(){
+        var result = parser.pick(['fr-CA', 'fr-FR', 'fr'], 'en-GB,en-US;q=0.9,fr-CA;q=0.7,en;q=0.8');
+        assert.equal(result, 'fr-CA');
+    });
+
+    it('parser.pick() loose', function(){
+        var result = parser.pick(['fr', 'en'], 'en-GB,en-US;q=0.9,fr-CA;q=0.7,en;q=0.8', { loose: true });
+        assert.equal(result, 'en');
+    });
 });