Skip to content

Commit 272ce1a

Browse files
deprecate computation name which is redundant.
PiperOrigin-RevId: 501941984
1 parent 0757438 commit 272ce1a

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

xla/service/buffer_value.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ LogicalBufferProto BufferValue::ToProto(const SizeFunction& size_fn) const {
5757
}
5858
// TODO(b/239098765): Stop populating these fields and delete them when
5959
// profiler finishes adaptation.
60+
proto.mutable_defined_at()->set_computation_name(
61+
instruction()->parent()->name());
6062
proto.mutable_defined_at()->set_instruction_name(instruction()->name());
6163
return proto;
6264
}

xla/service/hlo.proto

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -551,12 +551,13 @@ message LogicalBufferProto {
551551
// Location represents an instruction and its shape index, which uniquely
552552
// identifies a point where a buffer is needed.
553553
message Location {
554+
// NOTE: module_name isn't necessary, since all LogicalBuffers are
555+
// associated with a single HloModule.
554556
// TODO(b/239098765): Remove instruction_name and computation_name.
557+
string computation_name = 1 [deprecated = true];
555558
string instruction_name = 2 [deprecated = true];
556559
int64 instruction_id = 4;
557560
repeated int64 shape_index = 3;
558-
559-
reserved 1;
560561
}
561562

562563
int64 id = 1;

0 commit comments

Comments
 (0)