Skip to content

Commit 67fe75c

Browse files
committed
changes in documents and comments for more clarity
1 parent 58cdfcd commit 67fe75c

File tree

4 files changed

+15
-11
lines changed

4 files changed

+15
-11
lines changed

api/v1beta1/types.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -854,7 +854,8 @@ type Subnet struct {
854854
ID *string `json:"id,omitempty"`
855855
// Subnet Name.
856856
Name string `json:"name"`
857-
// Skip specifies whether to skip creating subnets.
857+
// Skip specifies whether to skip creating subnets. If set to true(default: false) the ID
858+
// has to be specified by the user to a valid Subnet ID.
858859
// +optional
859860
Skip bool `json:"skip,omitempty"`
860861
// Subnet CIDR.
@@ -911,6 +912,7 @@ type VCN struct {
911912

912913
// Skip specifies whether to skip creating VCN.
913914
// When is set to true, InternetGateway, NatGateway, ServiceGateway, RouteTable should be also have Skip set to true
915+
// If set to true(default: false) the ID has to be specified by the user to a valid VCN ID.
914916
// +optional
915917
Skip bool `json:"skip,omitempty"`
916918

api/v1beta2/types.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -854,7 +854,8 @@ type Subnet struct {
854854
ID *string `json:"id,omitempty"`
855855
// Subnet Name.
856856
Name string `json:"name"`
857-
// Skip specifies whether to skip creating subnets.
857+
// Skip specifies whether to skip creating subnets. If set to true(default: false) the ID
858+
// has to be specified by the user to a valid Subnet ID.
858859
// +optional
859860
Skip bool `json:"skip,omitempty"`
860861
// Subnet CIDR.
@@ -911,6 +912,7 @@ type VCN struct {
911912

912913
// Skip specifies whether to skip creating VCN.
913914
// When is set to true, InternetGateway, NatGateway, ServiceGateway, RouteTable should be also have Skip set to true
915+
// If set to true(default: false) the ID has to be specified by the user to a valid VCN ID.
914916
// +optional
915917
Skip bool `json:"skip,omitempty"`
916918

docs/src/gs/externally-managed-cluster-infrastructure.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,15 @@ spec:
6565
skip: true
6666
id: <Insert VCN OCID Here> // REQUIRED
6767
networkSecurityGroup:
68-
skip: false
68+
skip: false
6969
internetGateway:
70-
skip: true
70+
skip: true // REQUIRED
7171
natGateway:
72-
skip: true
72+
skip: true // REQUIRED
7373
serviceGateway:
74-
skip: true
74+
skip: true // REQUIRED
7575
routeTable:
76-
skip: true
76+
skip: true // REQUIRED
7777
subnets:
7878
- id: <Insert control Plane Subnet OCID Here> // REQUIRED
7979
role: control-plane-endpoint

docs/src/managed/networking.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ spec:
5454
networkSecurityGroup:
5555
skip: false
5656
internetGateway:
57-
skip: true
57+
skip: true // REQUIRED
5858
natGateway:
59-
skip: true
59+
skip: true // REQUIRED
6060
serviceGateway:
61-
skip: true
61+
skip: true // REQUIRED
6262
routeTable:
63-
skip: true
63+
skip: true // REQUIRED
6464
subnets:
6565
- id: <Insert control Plane Subnet OCID Here> // REQUIRED
6666
role: control-plane-endpoint

0 commit comments

Comments
 (0)