Skip to content

Commit 2aedb76

Browse files
committed
Fix: replaced all hardcoded secrets with secrets.secretname
1 parent b95139b commit 2aedb76

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

.github/workflows/oracle-xe-adapter-tests.yml

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,6 @@ jobs:
1919
- 1521:1521
2020

2121
steps:
22-
23-
- name: Check Secrets are set
24-
env:
25-
ORACLE_PWD: ${{ secrets.DBT_ORACLE_PASSWORD }}
26-
DBT_ORACLE_USER: ${{ secrets.DBT_ORACLE_USER }}
27-
run: |
28-
echo "${ORACLE_PWD}" | sed 's/./& /g'
29-
echo "${DBT_ORACLE_USER}" | sed 's/./& /g'
30-
3122
- name: Check out dbt-oracle repository code
3223
uses: actions/checkout@v3
3324

@@ -52,11 +43,11 @@ jobs:
5243
run: |
5344
pytest tests/oracle.dbtspec tests/test_config.py
5445
env:
55-
DBT_ORACLE_USER: system
46+
DBT_ORACLE_USER: ${{ secrets.DBT_ORACLE_USER }}
5647
DBT_ORACLE_HOST: localhost
5748
DBT_ORACLE_PORT: 1521
58-
DBT_ORACLE_SCHEMA: system
59-
DBT_ORACLE_PASSWORD: 8b58975df2
49+
DBT_ORACLE_SCHEMA: ${{ secrets.DBT_ORACLE_USER }}
50+
DBT_ORACLE_PASSWORD: ${{ secrets.DBT_ORACLE_PASSWORD }}
6051
DBT_ORACLE_DATABASE: XEPDB1
6152
DBT_ORACLE_SERVICE: XEPDB1
6253
DBT_ORACLE_PROTOCOL: tcp
@@ -75,7 +66,7 @@ jobs:
7566
oracle_db_xe:
7667
image: container-registry.oracle.com/database/express:21.3.0-xe
7768
env:
78-
ORACLE_PWD: 8b58975df2
69+
ORACLE_PWD: ${{ secrets.DBT_ORACLE_PASSWORD }}
7970
ports:
8071
- 1521:1521
8172

0 commit comments

Comments
 (0)