Review comments

Author: tkrodriguez

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/nodes/GraphState.java

@@ -561,6 +561,12 @@ public boolean isExplicitExceptionsNoDeopt() {
         return guardsStage == GuardsStage.FIXED_DEOPTS && isAfterStage(StageFlag.GUARD_LOWERING);
     }
 
+    /**
+     * Determines if {@link jdk.graal.compiler.nodes.memory.FloatingReadNode FloatingReadNodes} are
+     * allowed to be inserted. They should only be manually inserted if
+     * {@link jdk.graal.compiler.phases.common.FloatingReadPhase} has been run and
+     * {@link jdk.graal.compiler.phases.common.FixReadsPhase} has not.
+     */
     public boolean allowsFloatingReads() {
         return isAfterStage(StageFlag.FLOATING_READS) && isBeforeStage(StageFlag.FIXED_READS);
     }

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/replacements/SnippetTemplate.java

@@ -1213,7 +1213,7 @@ protected SnippetTemplate(OptionValues options,
                 boolean needsPEA = false;
                 boolean needsCE = false;
                 LoweringTool.LoweringStage loweringStage = args.cacheKey.loweringStage;
-                boolean allowsFloatingReads = args.cacheKey.allowsFloatingReads;
+                final boolean allowsFloatingReads = args.cacheKey.allowsFloatingReads;
                 for (Node n : snippetCopy.getNodes()) {
                     if (!needsPEA && (n instanceof AbstractNewObjectNode || n instanceof AbstractBoxingNode)) {
                         needsPEA = true;
@@ -1247,7 +1247,6 @@ protected SnippetTemplate(OptionValues options,
                 if (loweringStage != LoweringTool.StandardLoweringStage.HIGH_TIER) {
                     // (3)
                     assert !guardsStage.allowsFloatingGuards() : guardsStage;
-                    // Create memory map nodes
                     new FloatingReadPhase(true, allowsFloatingReads, canonicalizer).apply(snippetCopy, providers);
 
                     if (!snippetCopy.getGraphState().isExplicitExceptionsNoDeopt()) {