add more tests

Author: jhorwit2

pkg/provisioner/block/block_test.go

@@ -190,13 +190,21 @@ func TestGetTags(t *testing.T) {
 		expectedDefinedTags  map[string]map[string]interface{}
 		expectedFreeformTags map[string]string
 	}{
+		"no default or annotation tags": {
+			setup: func() {
+				os.Setenv(defaultTagsEnvVar, "")
+			},
+			annotations:          map[string]string{},
+			expectedDefinedTags:  map[string]map[string]interface{}{},
+			expectedFreeformTags: map[string]string{},
+		},
 		"valid tags only default": {
 			setup: func() {
-				os.Setenv(defaultTagsEnvVar, "namespace1.default=test,default=test")
+				os.Setenv(defaultTagsEnvVar, "defaultnamespace.default=test,default=test")
 			},
 			annotations: map[string]string{},
 			expectedDefinedTags: map[string]map[string]interface{}{
-				"namespace1": map[string]interface{}{
+				"defaultnamespace": map[string]interface{}{
 					"default": "test",
 				},
 			},
@@ -227,6 +235,22 @@ func TestGetTags(t *testing.T) {
 				"default": "test",
 			},
 		},
+		"override defaults with annotation": {
+			setup: func() {
+				os.Setenv(defaultTagsEnvVar, "namespace1.default=test,default=test")
+			},
+			annotations: map[string]string{
+				ociTagAnnotation: "namespace1.default=foo,default=bar",
+			},
+			expectedDefinedTags: map[string]map[string]interface{}{
+				"namespace1": map[string]interface{}{
+					"default": "foo",
+				},
+			},
+			expectedFreeformTags: map[string]string{
+				"default": "bar",
+			},
+		},
 	}
 
 	for name, tc := range testCases {