@@ -23,10 +23,10 @@ const SettingsEditor = (() => {
2323 let beforeEditingPreferences ;
2424 const scratchPath = `${ app . getPath ( 'userData' ) } /scratch-settings.json` ;
2525
26- let dontNeedStore = ( preferences ) => {
26+ const dontNeedStoreFile = ( preferences ) => {
2727 if ( ! preferences . networking . trustStoreType )
2828 return true ;
29- if ( ! preferences . networking . trustStoreType === '' )
29+ if ( preferences . networking . trustStoreType === '' )
3030 return true ;
3131 if ( / ^ W i n d o w s - [ A - Z ] + $ / . test ( preferences . networking . trustStoreType ) )
3232 return true ;
@@ -35,6 +35,13 @@ const SettingsEditor = (() => {
3535 return false ;
3636 } ;
3737
38+ function trustStoreTypeRequiresStore ( ) {
39+ // This looks a little weird, but this is how the "hide function" is
40+ // invoked in electron-preferences and this is a quick way of sharing
41+ // the code.
42+ return ! dontNeedStoreFile ( preferences . _preferences ) ;
43+ }
44+
3845 function load ( ) {
3946 const path = ConfigJSON . getPath ( ) ;
4047 let data = { } ;
@@ -58,8 +65,8 @@ const SettingsEditor = (() => {
5865 else if ( key === 'javax.net.ssl.trustStore' ) {
5966 preferences . value ( 'networking.trustStore' , data [ key ] ) ;
6067 }
61- else if ( key === 'javax.net.ssl.trustStoreKey ' ) {
62- preferences . value ( 'networking.trustStoreKey ' , data [ key ] ) ;
68+ else if ( key === 'javax.net.ssl.trustStorePassword ' ) {
69+ preferences . value ( 'networking.trustStorePassword ' , data [ key ] ) ;
6370 }
6471 else if ( key === 'console.connectTimeoutMillis' ) {
6572 preferences . value ( 'networking.connectTimeoutMillis' , data [ key ] ) ;
@@ -90,10 +97,10 @@ const SettingsEditor = (() => {
9097 const path = ConfigJSON . getPath ( ) ;
9198 let data = { } ;
9299 addValue ( data , 'proxy' , preferences . value ( 'networking.proxy' ) ) ;
93- if ( ! dontNeedStore ) {
94- addValue ( data , 'javax.net.ssl.trustStoreType' , preferences . value ( 'networking.trustStoreType' ) ) ;
100+ addValue ( data , 'javax.net.ssl.trustStoreType' , preferences . value ( 'networking.trustStoreType' ) ) ;
101+ if ( trustStoreTypeRequiresStore ( ) ) {
95102 addValue ( data , 'javax.net.ssl.trustStore' , preferences . value ( 'networking.trustStore' ) ) ;
96- addValue ( data , 'javax.net.ssl.trustStoreKey ' , preferences . value ( 'networking.trustStoreKey ' ) ) ;
103+ addValue ( data , 'javax.net.ssl.trustStorePassword ' , preferences . value ( 'networking.trustStorePassword ' ) ) ;
97104 }
98105 addValue ( data , 'console.connectTimeoutMillis' , preferences . value ( 'networking.connectTimeoutMillis' ) ) ;
99106 addValue ( data , 'console.readTimeoutMillis' , preferences . value ( 'networking.readTimeoutMillis' ) ) ;
@@ -207,13 +214,13 @@ const SettingsEditor = (() => {
207214 key : 'trustStore' ,
208215 buttonLabel : `${ I18NUtils . get ( 'wrc-electron.menus.settings.trust-store.path.button.label' ) } ` ,
209216 type : 'file' ,
210- hideFunction : dontNeedStore
217+ hideFunction : dontNeedStoreFile
211218 } ,
212219 {
213220 label : `${ I18NUtils . get ( 'wrc-electron.menus.settings.trust-store.key.label' ) } ` ,
214- key : 'trustStoreKey ' ,
221+ key : 'trustStorePassword ' ,
215222 type : 'text' ,
216- hideFunction : dontNeedStore
223+ hideFunction : dontNeedStoreFile
217224 } ,
218225 {
219226 label : `${ I18NUtils . get ( 'wrc-electron.menus.settings.connect-timeout.label' ) } ` ,
0 commit comments