-
-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
To prevent additional build sizes of applications, @osjs/gui
could be provded by the service provider this package provides via window.osjsGui
just as the UMD module does.
As far as I know there's no way to use a webpack generated module as both a global and included module. So if I were to do window.osjsGui = osjsGui
where import * as osjsGui from 'index.js'
would not create a ES5 compatible object since they all will be of the type Module
.
Would be nice to sort this out without loading an additional @osjs/gui
bundle file.
This way apps can just use this in the webpack config instead of having it as a dependency:
module.export = {
externals: {
'@osjs/gui': 'osjsGui'
}
};
No changes required in the actual implementations:
import {foo} from '@osjs/gui';
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed